third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 2208463003: First step of PaintInvalidator implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2208463003: First step of PaintInvalidator implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index 3ea4a8860e85050dcc59996cc8ac3300c77f712a..239fc14c2afdc738acc1415d86e3eb3c27c5da48 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -379,7 +379,7 @@ static bool hasPercentageTransform(const ComputedStyle& style)

void LayoutBoxModelObject::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvalidationState)

{

- ASSERT(!needsLayout());

+ ensureIsReadyForPaintInvalidation();

PaintInvalidationState newPaintInvalidationState(paintInvalidationState, *this);

if (!shouldCheckForPaintInvalidation(newPaintInvalidationState))

@@ -391,7 +391,7 @@ void LayoutBoxModelObject::invalidateTreeIfNeeded(const PaintInvalidationState&

LayoutRect previousPaintInvalidationRect = this->previousPaintInvalidationRect();

LayoutPoint previousPosition = previousPositionFromPaintInvalidationBacking();

PaintInvalidationReason reason = invalidatePaintIfNeeded(newPaintInvalidationState);

- clearPaintInvalidationFlags(newPaintInvalidationState);

+ clearPaintInvalidationFlags();

if (previousPosition != previousPositionFromPaintInvalidationBacking())

newPaintInvalidationState.setForceSubtreeInvalidationCheckingWithinContainer();