Changes accelerators registered by mus to not interfere with those of client

Changes accelerators registered by mus to not interfere with those of client

Also converts away from using EventMatcher for these accelerators as
EventMatcher is overkill here. If we really need to use EventMatcher
we can do that later on.

This results in a bit of duplication for ctrl-alt-shift-s, but I think
that's ok.

BUG=633270
TEST=none
R=jamescook@chromium.org

Committed: https://crrev.com/5aafc35e42348c0aedfee277e27d7c4f920b3122
Cr-Commit-Position: refs/heads/master@{#409629}

[sky, 2016-08-02 19:19:25]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 19:20:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 20:05:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 20:05:28]

Dry run: This issue passed the CQ dry run.

[sky, 2016-08-03 15:32:01]

Description was changed from

==========
Changes accelerators registered by mus to not interfere with those of client

Also converts away from using EventMatcher for these accelerators as
EventMatcher is overkill here. If we really need to use EventMatcher
we can do that later on.

This results in a bit of duplication for ctrl-alt-shift-s, but I think
that's ok.

BUG=633270
TEST=none
R=jamescook@chromium.org
==========

to

==========
Changes accelerators registered by mus to not interfere with those of client

Also converts away from using EventMatcher for these accelerators as
EventMatcher is overkill here. If we really need to use EventMatcher
we can do that later on.

This results in a bit of duplication for ctrl-alt-shift-s, but I think
that's ok.

BUG=633270
TEST=none
R=jamescook@chromium.org
==========

[sky, 2016-08-03 15:32:01]

sky@chromium.org changed reviewers:
+ sadrul@chromium.org
- jamescook@chromium.org

[sky, 2016-08-03 15:32:20]

James is ooo, so james->sadrul

[sadrul, 2016-08-03 16:19:24]

It seems a bit unfortunate to have mus installing accelerators itself. Can we
expose a WindowServerDebug interface (like WindowServerTest) instead which mus
exposes when some command-line flag is used? That way, the debug code can live
in ash, and doesn't need special handling in mus.

[sky, 2016-08-03 16:29:11]

These accelerators are just for debugging and only installed in debug
builds. I don't think it warrants a special interface. It may be
useful outside of ash.

  -Scott

On Wed, Aug 3, 2016 at 9:19 AM,  <sadrul@chromium.org> wrote:
> It seems a bit unfortunate to have mus installing accelerators itself. Can
> we
> expose a WindowServerDebug interface (like WindowServerTest) instead which
> mus
> exposes when some command-line flag is used? That way, the debug code can
> live
> in ash, and doesn't need special handling in mus.
>
> https://codereview.chromium.org/2208443002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sadrul, 2016-08-03 20:14:14]

lgtm

[sky, 2016-08-03 20:48:20]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-08-03 20:49:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:45:17]

Description was changed from

==========
Changes accelerators registered by mus to not interfere with those of client

Also converts away from using EventMatcher for these accelerators as
EventMatcher is overkill here. If we really need to use EventMatcher
we can do that later on.

This results in a bit of duplication for ctrl-alt-shift-s, but I think
that's ok.

BUG=633270
TEST=none
R=jamescook@chromium.org
==========

to

==========
Changes accelerators registered by mus to not interfere with those of client

Also converts away from using EventMatcher for these accelerators as
EventMatcher is overkill here. If we really need to use EventMatcher
we can do that later on.

This results in a bit of duplication for ctrl-alt-shift-s, but I think
that's ok.

BUG=633270
TEST=none
R=jamescook@chromium.org
==========

[commit-bot: I haz the power, 2016-08-03 21:45:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-03 21:47:18]

Description was changed from

==========
Changes accelerators registered by mus to not interfere with those of client

Also converts away from using EventMatcher for these accelerators as
EventMatcher is overkill here. If we really need to use EventMatcher
we can do that later on.

This results in a bit of duplication for ctrl-alt-shift-s, but I think
that's ok.

BUG=633270
TEST=none
R=jamescook@chromium.org
==========

to

==========
Changes accelerators registered by mus to not interfere with those of client

Also converts away from using EventMatcher for these accelerators as
EventMatcher is overkill here. If we really need to use EventMatcher
we can do that later on.

This results in a bit of duplication for ctrl-alt-shift-s, but I think
that's ok.

BUG=633270
TEST=none
R=jamescook@chromium.org

Committed: https://crrev.com/5aafc35e42348c0aedfee277e27d7c4f920b3122
Cr-Commit-Position: refs/heads/master@{#409629}
==========

[commit-bot: I haz the power, 2016-08-03 21:47:19]

Patchset 2 (id:??) landed as
https://crrev.com/5aafc35e42348c0aedfee277e27d7c4f920b3122
Cr-Commit-Position: refs/heads/master@{#409629}