Distinguish identical messages with different meanings

Distinguish identical messages with different meanings

There are three 'Tab' in grd files across Chromium tree. Two of them
refer to a UI element (e.g. browser tab) tab while the third one
refers to Tab key.

Without 'meaning' field in grd, they're unified ('desc' does not
count when calculating a message ID !!) and sent for translation
as one message.

Add 'meaning' field so that the former is distinguished from the latter.

BUG=613776
TEST=Message Ids (internal) generated by grd_to_xmb are different. (internal)
TEST=Message Ids (chromium) output by map_id are distinctt. (internal)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4b276f44f50714b0a24a290ab58c7caf761fbc1c
Cr-Commit-Position: refs/heads/master@{#409726}

[jungshik at Google, 2016-08-03 00:08:16]

Description was changed from

==========
Distinguish identical messages with different meanings

There are three 'Tab' in grd files across Chromium tree. Two of them
refer to a UI element (e.g. browser tab) tab while the third one
refers to Tab key.

Without 'meaning' field in grd, they're unified ('desc' does not
count when calculating a message ID !!) and sent for translation
as one message.

Add 'meaning' field so that they're distinguished.

BUG=613776
TEST=Message Ids generated are different.
==========

to

==========
Distinguish identical messages with different meanings

There are three 'Tab' in grd files across Chromium tree. Two of them
refer to a UI element (e.g. browser tab) tab while the third one
refers to Tab key.

Without 'meaning' field in grd, they're unified ('desc' does not
count when calculating a message ID !!) and sent for translation
as one message.

Add 'meaning' field so that they're distinguished.

BUG=613776
TEST=Message Ids generated are different.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jungshik at Google, 2016-08-03 00:20:21]

jshin@chromium.org changed reviewers:
+ dmazzoni@chromium.org, grt@chromium.org, thakis@chromium.org

[jungshik at Google, 2016-08-03 00:20:22]

dmazzoni@chromium.org: chromevox and chrome/app : both are about Aria role Tab. 


grt@chromium.org: chrome/app

avi@chromium.org: ui/*.

[jungshik at Google, 2016-08-03 00:21:27]

Can you take a look? Thanks ! (note that 'meaning' is not sent to translators
while 'desc' is. SO, 'meaning' is only used to distinguish identical messages
with different meanings). 

On 2016/08/03 00:20:22, jungshik at google wrote:
> https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=dmazzoni@chromium.org:
chromevox and chrome/app : both are about Aria role Tab. 
> 
> 
> https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=grt@chromium.org:
chrome/app
> 
> https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=avi@chromium.org: ui/*.

[grt (UTC plus 2), 2016-08-03 07:18:05]

i'll trust the other reviewers; chrome/app rubber-stamp lgtm.

[jungshik at Google, 2016-08-03 19:01:11]

Description was changed from

==========
Distinguish identical messages with different meanings

There are three 'Tab' in grd files across Chromium tree. Two of them
refer to a UI element (e.g. browser tab) tab while the third one
refers to Tab key.

Without 'meaning' field in grd, they're unified ('desc' does not
count when calculating a message ID !!) and sent for translation
as one message.

Add 'meaning' field so that they're distinguished.

BUG=613776
TEST=Message Ids generated are different.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Distinguish identical messages with different meanings

There are three 'Tab' in grd files across Chromium tree. Two of them
refer to a UI element (e.g. browser tab) tab while the third one
refers to Tab key.

Without 'meaning' field in grd, they're unified ('desc' does not
count when calculating a message ID !!) and sent for translation
as one message.

Add 'meaning' field so that they're distinguished.

BUG=613776
TEST=Message Ids (internal) generated by grd_to_xmb are different.
TEST=Message Ids (chromium) output by map_id are distinctt.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jungshik at Google, 2016-08-03 19:11:06]

Description was changed from

==========
Distinguish identical messages with different meanings

There are three 'Tab' in grd files across Chromium tree. Two of them
refer to a UI element (e.g. browser tab) tab while the third one
refers to Tab key.

Without 'meaning' field in grd, they're unified ('desc' does not
count when calculating a message ID !!) and sent for translation
as one message.

Add 'meaning' field so that they're distinguished.

BUG=613776
TEST=Message Ids (internal) generated by grd_to_xmb are different.
TEST=Message Ids (chromium) output by map_id are distinctt.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Distinguish identical messages with different meanings

There are three 'Tab' in grd files across Chromium tree. Two of them
refer to a UI element (e.g. browser tab) tab while the third one
refers to Tab key.

Without 'meaning' field in grd, they're unified ('desc' does not
count when calculating a message ID !!) and sent for translation
as one message.

Add 'meaning' field so that the former is distinguished from the latter.

BUG=613776
TEST=Message Ids (internal) generated by grd_to_xmb are different. (internal)
TEST=Message Ids (chromium) output by map_id are distinctt. (internal)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-08-03 19:35:42]

lgtm

[jungshik at Google, 2016-08-03 20:13:55]

The CQ bit was checked by jshin@chromium.org

[commit-bot: I haz the power, 2016-08-03 20:14:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:32:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:32:42]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jungshik at Google, 2016-08-04 05:37:57]

The CQ bit was checked by jshin@chromium.org

[commit-bot: I haz the power, 2016-08-04 05:38:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 06:09:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-04 06:10:38]

Description was changed from

==========
Distinguish identical messages with different meanings

There are three 'Tab' in grd files across Chromium tree. Two of them
refer to a UI element (e.g. browser tab) tab while the third one
refers to Tab key.

Without 'meaning' field in grd, they're unified ('desc' does not
count when calculating a message ID !!) and sent for translation
as one message.

Add 'meaning' field so that the former is distinguished from the latter.

BUG=613776
TEST=Message Ids (internal) generated by grd_to_xmb are different. (internal)
TEST=Message Ids (chromium) output by map_id are distinctt. (internal)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Distinguish identical messages with different meanings

There are three 'Tab' in grd files across Chromium tree. Two of them
refer to a UI element (e.g. browser tab) tab while the third one
refers to Tab key.

Without 'meaning' field in grd, they're unified ('desc' does not
count when calculating a message ID !!) and sent for translation
as one message.

Add 'meaning' field so that the former is distinguished from the latter.

BUG=613776
TEST=Message Ids (internal) generated by grd_to_xmb are different. (internal)
TEST=Message Ids (chromium) output by map_id are distinctt. (internal)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4b276f44f50714b0a24a290ab58c7caf761fbc1c
Cr-Commit-Position: refs/heads/master@{#409726}
==========

[commit-bot: I haz the power, 2016-08-04 06:10:39]

Patchset 1 (id:??) landed as
https://crrev.com/4b276f44f50714b0a24a290ab58c7caf761fbc1c
Cr-Commit-Position: refs/heads/master@{#409726}