xfa/fde/cfde_txtedtbuf.h - Issue 2208423002: Use smart pointers for class owned pointers under xfa/fde

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: xfa/fde/cfde_txtedtbuf.h

Issue 2208423002: Use smart pointers for class owned pointers under xfa/fde (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef XFA_FDE_CFDE_TXTEDTBUF_H_	7 #ifndef XFA_FDE_CFDE_TXTEDTBUF_H_

8 #define XFA_FDE_CFDE_TXTEDTBUF_H_	8 #define XFA_FDE_CFDE_TXTEDTBUF_H_

9	9

	10 #include <memory>

	11

10 #include "core/fxcrt/include/fx_basic.h"	12 #include "core/fxcrt/include/fx_basic.h"

11 #include "core/fxcrt/include/fx_system.h"	13 #include "core/fxcrt/include/fx_system.h"

12	14

13 class IFX_MemoryAllocator;	15 class IFX_MemoryAllocator;

14 class IFX_Pause;	16 class IFX_Pause;

15	17

16 class CFDE_TxtEdtBuf {	18 class CFDE_TxtEdtBuf {

17 public:	19 public:

18 CFDE_TxtEdtBuf();	20 CFDE_TxtEdtBuf();

19 ~CFDE_TxtEdtBuf();	21 ~CFDE_TxtEdtBuf();

(...skipping 28 matching lines...) Expand all Loading...
48	50

49 void ResetChunkBuffer(int32_t nDefChunkCount, int32_t nChunkSize);	51 void ResetChunkBuffer(int32_t nDefChunkCount, int32_t nChunkSize);

50 int32_t CP2Index(const FDE_CHUNKPLACE& cp) const;	52 int32_t CP2Index(const FDE_CHUNKPLACE& cp) const;

51 void Index2CP(int32_t nIndex, FDE_CHUNKPLACE& cp) const;	53 void Index2CP(int32_t nIndex, FDE_CHUNKPLACE& cp) const;

52	54

53 int32_t m_nChunkSize;	55 int32_t m_nChunkSize;

54	56

55 int32_t m_nTotal;	57 int32_t m_nTotal;

56 FX_BOOL m_bChanged;	58 FX_BOOL m_bChanged;

57 CFX_ArrayTemplate<FDE_CHUNKHEADER*> m_Chunks;	59 CFX_ArrayTemplate<FDE_CHUNKHEADER*> m_Chunks;

58 IFX_MemoryAllocator* m_pAllocator;	60 std::unique_ptr<IFX_MemoryAllocator> m_pAllocator;

59 };	61 };

60	62

61 #endif // XFA_FDE_CFDE_TXTEDTBUF_H_	63 #endif // XFA_FDE_CFDE_TXTEDTBUF_H_

OLD	NEW

« no previous file with comments | « no previous file | xfa/fde/cfde_txtedtbuf.cpp » ('j') | xfa/fde/css/fde_cssstyleselector.h » ('J')