Eliminate HAVE(ERRNO_H) guard.

Eliminate HAVE(ERRNO_H).

errno.h is available on all platforms that blink supports including Windows. HAVE(ERRNO_H) is used in WebKit to support WinCE which is not a supported platform for blink.

In DateMath.cpp errno is not used, so no need to include errno.h.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155493

[lgombos, 2013-08-04 09:15:44]

This is part of the effort to eliminate build time flags.

[eseidel, 2013-08-04 17:59:38]

Lgtm
On Aug 4, 2013 2:15 AM, <l.gombos@samsung.com> wrote:

> Reviewers: jamesr, abarth, eseidel,
>
> Message:
> This is part of the effort to eliminate build time flags.
>
> Description:
> Eliminate HAVE(ERRNO_H).
>
> errno.h is available on all platforms that blink supports including
> Windows.
> HAVE(ERRNO_H) is used in WebKit to support WinCE which is not a supported
> platform for blink.
>
> In DateMath.cpp errno is not used, so no need to include errno.h.
>
> Please review this at
https://codereview.chromium.**org/22084002/<https://codereview.chromium.org/2...
>
> SVN Base:
https://chromium.googlesource.**com/chromium/blink.git@master<https://chromiu...
>
> Affected files:
>   M Source/wtf/DateMath.cpp
>   M Source/wtf/FastMalloc.cpp
>   M Source/wtf/Platform.h
>   M Source/wtf/ThreadingWin.cpp
>
>
> Index: Source/wtf/DateMath.cpp
> diff --git a/Source/wtf/DateMath.cpp b/Source/wtf/DateMath.cpp
> index b632763ce50a3fa035f998feadbfd4**943c750c56..**
> 5bc9abc6e6b989f32626bced3883bc**f0c16216ed 100644
> --- a/Source/wtf/DateMath.cpp
> +++ b/Source/wtf/DateMath.cpp
> @@ -90,10 +90,6 @@
>  #include <windows.h>
>  #endif
>
> -#if HAVE(ERRNO_H)
> -#include <errno.h>
> -#endif
> -
>  #if HAVE(SYS_TIME_H)
>  #include <sys/time.h>
>  #endif
> Index: Source/wtf/FastMalloc.cpp
> diff --git a/Source/wtf/FastMalloc.cpp b/Source/wtf/FastMalloc.cpp
> index f2b882d7e90436101a99cff7980076**da983615bd..**
> d2545f7ef20dfda5e87192422e8184**386e11b42b 100644
> --- a/Source/wtf/FastMalloc.cpp
> +++ b/Source/wtf/FastMalloc.cpp
> @@ -411,14 +411,12 @@ extern "C"  const int jscore_fastmalloc_**introspection
> = 0;
>  #include "TCSpinLock.h"
>  #include "TCSystemAlloc.h"
>  #include <algorithm>
> +#include <errno.h>
>  #include <pthread.h>
>  #include <stdarg.h>
>  #include <stddef.h>
>  #include <stdint.h>
>  #include <stdio.h>
> -#if HAVE(ERRNO_H)
> -#include <errno.h>
> -#endif
>  #if OS(UNIX)
>  #include <unistd.h>
>  #endif
> @@ -2962,12 +2960,10 @@ ALWAYS_INLINE void
TCMalloc_Central_FreeList::**Populate()
> {
>      if (span) pageheap->RegisterSizeClass(**span, size_class_);
>    }
>    if (span == NULL) {
> -#if HAVE(ERRNO_H)
> -    MESSAGE("allocation failed: %d\n", errno);
> -#elif OS(WINDOWS)
> +#if OS(WINDOWS)
>      MESSAGE("allocation failed: %d\n", ::GetLastError());
>  #else
> -    MESSAGE("allocation failed\n");
> +    MESSAGE("allocation failed: %d\n", errno);
>  #endif
>      lock_.Lock();
>      return;
> Index: Source/wtf/Platform.h
> diff --git a/Source/wtf/Platform.h b/Source/wtf/Platform.h
> index 1fe86d3de0abf715e3f5f3eab7299c**272e16e0f6..**
> a39883d3513a2123e73538626dfe54**22ddee103d 100644
> --- a/Source/wtf/Platform.h
> +++ b/Source/wtf/Platform.h
> @@ -136,7 +136,6 @@
>  #endif /* !defined(HAVE_ACCESSIBILITY) */
>
>  #if OS(UNIX)
> -#define HAVE_ERRNO_H 1
>  #define HAVE_MMAP 1
>  #define HAVE_SIGNAL_H 1
>  #define HAVE_STRINGS_H 1
> Index: Source/wtf/ThreadingWin.cpp
> diff --git a/Source/wtf/ThreadingWin.cpp b/Source/wtf/ThreadingWin.cpp
> index f12679fc1c14d98eacaf6f4a8d471c**6725101d42..**
> 1716a158b6abb704557121c6c10059**848df0ef6c 100644
> --- a/Source/wtf/ThreadingWin.cpp
> +++ b/Source/wtf/ThreadingWin.cpp
> @@ -107,11 +107,8 @@
>  #include "ThreadSpecific.h"
>  #endif
>
> -#include <process.h>
> -
> -#if HAVE(ERRNO_H)
>  #include <errno.h>
> -#endif
> +#include <process.h>
>
>  namespace WTF {
>
> @@ -223,11 +220,7 @@ ThreadIdentifier createThreadInternal(**ThreadFunction
> entryPoint, void* data, con
>      OwnPtr<**ThreadFunctionInvocation> invocation = adoptPtr(new
> ThreadFunctionInvocation(**entryPoint, data));
>      HANDLE threadHandle = reinterpret_cast<HANDLE>(_**beginthreadex(0,
> 0, wtfThreadEntryPoint, invocation.get(), 0, &threadIdentifier));
>      if (!threadHandle) {
> -#if !HAVE(ERRNO_H)
> -        LOG_ERROR("Failed to create thread at entry point %p with data
> %p.", entryPoint, data);
> -#else
>          LOG_ERROR("Failed to create thread at entry point %p with data
> %p: %ld", entryPoint, data, errno);
> -#endif
>          return 0;
>      }
>
>
>
>

[commit-bot: I haz the power, 2013-08-04 18:26:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/22084002/3001

[commit-bot: I haz the power, 2013-08-04 21:37:52]

Change committed as 155493