MD Settings: Ensure sections are shown

chrome/browser/resources/settings/settings_page/main_page_behavior.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Fast out, slow in.
 var EASING_FUNCTION = 'cubic-bezier(0.4, 0, 0.2, 1)';
 var EXPAND_DURATION = 350;
 
 /**
  * Calls |readyTest| repeatedly until it returns true, then calls
@@ skipping 37 matching lines @@
   },
 
   /**
    * Hides or unhides the sections not being expanded.
    * @param {string} sectionName The section to keep visible.
    * @param {boolean} hidden Whether the sections should be hidden.
    * @private
    */
   toggleOtherSectionsHidden_: function(sectionName, hidden) {
     var sections = Polymer.dom(this.root).querySelectorAll(
-        this.sectionSelector + ':not([section=' + sectionName + '])');
+        this.sectionSelector);
     for (var section of sections)
-      section.hidden = hidden;
+      section.hidden = hidden && (section.section != sectionName);

[Dan Beam, 2016/08/04 01:10:27]

nit that i didn't bother to previously say: i don't know that these () really
add enough to merit being there, but if you reallly think they add to
readability, sure

[michaelpg, 2016/08/04 01:36:42]

i'm really stingy with my parens, which used to be a common nit, so I compensate
by using them more. different operators being used together tends to confuse
people

   },
 
   /**
    * Animates the card in |section|, expanding it to fill the page.
    * @param {!SettingsSectionElement} section
    */
   expandSection: function(section) {
     // If another section's card is expanding, cancel that animation first.
     var expanding = this.$$('.expanding');
     if (expanding) {
@@ skipping 356 matching lines @@
         this.$$('[section=' + section + ']'));
   },
 };
 
 
 /** @polymerBehavior */
 var RoutableBehavior = [
   MainPageBehavior,
   RoutableBehaviorImpl
 ];