[Offline Pages] Add new download namespace

[Offline Pages] Add new download namespace

BUG=630817
Committed: https://crrev.com/95772ca18525a1d0d673ff755f1921df38a3b0dd
Cr-Commit-Position: refs/heads/master@{#409939}

[chili, 2016-08-04 00:10:52]

The CQ bit was checked by chili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 00:11:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 00:43:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 00:43:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[chili, 2016-08-04 00:50:05]

chili@chromium.org changed reviewers:
+ dewittj@chromium.org, fgorski@chromium.org

[fgorski, 2016-08-04 06:05:41]

lgtm

https://codereview.chromium.org/2208293002/diff/20001/components/offline_page...
File components/offline_pages/client_policy_controller.cc (right):

https://codereview.chromium.org/2208293002/diff/20001/components/offline_page...
components/offline_pages/client_policy_controller.cc:39:
base::TimeDelta::FromDays(2),
this value is/should be irrelevant for PERSISTENT namespaces, could you try
setting it o 0?

https://codereview.chromium.org/2208293002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2208293002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:99684: +  <suffix name="download"
label="Offline downloads"/>
label="Downloaded offline pages"

[chili, 2016-08-04 06:53:27]

chili@chromium.org changed reviewers:
+ holte@chromium.org

[chili, 2016-08-04 06:53:28]

+holte for histograms

https://codereview.chromium.org/2208293002/diff/20001/components/offline_page...
File components/offline_pages/client_policy_controller.cc (right):

https://codereview.chromium.org/2208293002/diff/20001/components/offline_page...
components/offline_pages/client_policy_controller.cc:39:
base::TimeDelta::FromDays(2),
On 2016/08/04 06:05:41, fgorski wrote:
> this value is/should be irrelevant for PERSISTENT namespaces, could you try
> setting it o 0?

Done.

https://codereview.chromium.org/2208293002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2208293002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:99684: +  <suffix name="download"
label="Offline downloads"/>
On 2016/08/04 06:05:41, fgorski wrote:
> label="Downloaded offline pages"

Changed to "Offline downloaded pages" to keep current semantic of starting with
"offline"

[Steven Holte, 2016-08-04 17:59:12]

histograms lgtm

[chili, 2016-08-04 23:03:55]

The CQ bit was checked by chili@chromium.org

[chili, 2016-08-04 23:03:56]

The patchset sent to the CQ was uploaded after l-g-t-m from fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/2208293002/#ps40001
(title: "Update according to review comments")

[commit-bot: I haz the power, 2016-08-04 23:04:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 00:12:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-05 00:15:51]

Description was changed from

==========
[Offline Pages] Add new download namespace

BUG=630817
==========

to

==========
[Offline Pages] Add new download namespace

BUG=630817

Committed: https://crrev.com/95772ca18525a1d0d673ff755f1921df38a3b0dd
Cr-Commit-Position: refs/heads/master@{#409939}
==========

[commit-bot: I haz the power, 2016-08-05 00:15:52]

Patchset 3 (id:??) landed as
https://crrev.com/95772ca18525a1d0d673ff755f1921df38a3b0dd
Cr-Commit-Position: refs/heads/master@{#409939}