Issue 2208223002: Allow weird characters (like ?) to appear in devfs filenames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2208223002: Allow weird characters (like ?) to appear in devfs filenames. (Closed)

Created:
4 years, 4 months ago by turnidge

Modified:
4 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -1 line)			Patch
	M	runtime/observatory/tests/service/dev_fs_test.dart	View		1 chunk	+44 lines, -0 lines	0 comments	Download
	M	sdk/lib/vmservice/devfs.dart	View		2 chunks	+13 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Cutch

LGTM assuming filenames on disk don't end up percent encoded unnecessarily.

4 years, 4 months ago (2016-08-03 22:35:57 UTC) #3

turnidge

4 years, 4 months ago (2016-08-03 22:43:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
74ad64038a3b9c4f83c29058b4317b31d4cf637c (presubmit successful).