Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2208173002: Plugin Power Saver Tiny: Add Unthrottle by Omnibox bucket to histogram. (Closed)

Created:
4 years, 4 months ago by tommycli
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, groby-ooo-7-16
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver Tiny: Add Unthrottle by Omnibox bucket to histogram. BUG=634130 Committed: https://crrev.com/1b406105b4d81e402003e8dd1a11f20cb52fe5cc Cr-Commit-Position: refs/heads/master@{#410112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M components/plugins/renderer/loadable_plugin_placeholder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/renderer/plugin_instance_throttler.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
tommycli
bauerb: PTAL To confirm, the OnLoadBlockedPlugins is only used for when the user clicks "Run ...
4 years, 4 months ago (2016-08-03 21:16:48 UTC) #2
Bernhard Bauer
lgtm
4 years, 4 months ago (2016-08-04 12:46:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208173002/1
4 years, 4 months ago (2016-08-04 16:08:57 UTC) #5
tommycli
isherman: PTAL tools/ thanks!
4 years, 4 months ago (2016-08-04 16:09:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/231155)
4 years, 4 months ago (2016-08-04 16:16:28 UTC) #9
Ilya Sherman
histograms.xml lgtm
4 years, 4 months ago (2016-08-04 20:04:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208173002/1
4 years, 4 months ago (2016-08-04 20:23:44 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/231396)
4 years, 4 months ago (2016-08-04 20:30:33 UTC) #14
tommycli
piman: PTAL 1 line content/public - thanks
4 years, 4 months ago (2016-08-04 20:47:37 UTC) #16
piman
lgtm
4 years, 4 months ago (2016-08-05 00:55:20 UTC) #17
tommycli
thanks all!
4 years, 4 months ago (2016-08-05 16:09:59 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208173002/1
4 years, 4 months ago (2016-08-05 16:10:08 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 18:15:05 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 18:19:16 UTC) #23
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1b406105b4d81e402003e8dd1a11f20cb52fe5cc
Cr-Commit-Position: refs/heads/master@{#410112}

Powered by Google App Engine
This is Rietveld 408576698