[Findit] Filters for dashboard

appengine/findit/handlers/flake/filter_flake.py

Index: appengine/findit/handlers/flake/filter_flake.py
diff --git a/appengine/findit/handlers/flake/filter_flake.py b/appengine/findit/handlers/flake/filter_flake.py
new file mode 100644
index 0000000000000000000000000000000000000000..83b032ff2c7e0c5ae8a172acd9f2ce08370fec84
--- /dev/null
+++ b/appengine/findit/handlers/flake/filter_flake.py
@@ -0,0 +1,49 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from google.appengine.ext import ndb
+
+from common.base_handler import BaseHandler
+from common.base_handler import Permission
+from model.flake.master_flake_analysis import MasterFlakeAnalysis
+
+
+class FilterFlake(BaseHandler):
+  PERMISSION_LEVEL = Permission.CORP_USER
+
+
+

[chanli, 2016/08/03 21:32:50]

Too many empty lines

[caiw, 2016/08/05 20:35:08]

Done.

+  def HandleGet(self):
+    master_name = self.request.get('master_name').strip()
+    builder_name = self.request.get('builder_name').strip()
+    build_number = self.request.get('build_number').strip()
+    if build_number:
+      build_number = int(build_number)
+    step_name = self.request.get('step_name').strip()
+    test_name = self.request.get('test_name').strip()
+
+    master_flake_analyses = MasterFlakeAnalysis.query()

[chanli, 2016/08/03 21:32:50]

Nit: change this argument name to things like master_flake_analyses_query?

[lijeffrey, 2016/08/04 21:03:21]

nit for the nit: master_flake_analysis_query

[caiw, 2016/08/05 20:35:08]

Done.

+    if master_name:
+      master_flake_analyses = master_flake_analyses.filter(

[lijeffrey, 2016/08/04 21:03:21]

nit: you can move the filtering part to a separate function to make unit testing
more possible

[caiw, 2016/08/05 20:35:08]

Done.

+          MasterFlakeAnalysis.master_name==master_name)
+    if builder_name:
+      master_flake_analyses = master_flake_analyses.filter(
+          MasterFlakeAnalysis.builder_name==builder_name)
+    if build_number:
+      master_flake_analyses = master_flake_analyses.filter(
+          MasterFlakeAnalysis.build_number==build_number)
+    if step_name:
+      master_flake_analyses = master_flake_analyses.filter(
+          MasterFlakeAnalysis.step_name==step_name)
+    if test_name:
+      master_flake_analyses = master_flake_analyses.filter(
+          MasterFlakeAnalysis.test_name==test_name)
+    master_flake_analyses = master_flake_analyses.fetch()
+    data = {
+        'master_flake_analyses': master_flake_analyses
+    }
+    return {
+        'template': 'flake/dashboard.html',
+        'data': data
+    }