Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 220813004: Reset the window before its acquired layer is deleted (Closed)

Created:
6 years, 8 months ago by oshima
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Reset the window before its acquired layer is deleted BUG=None TEST=This should be covered by memory bot. (valgrind/asan should catch this). I'll file a request to add wm_core_unittests to memory bots. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261520

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/wm/core/window_util_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
oshima
6 years, 8 months ago (2014-04-03 20:11:01 UTC) #1
sky
LGTM
6 years, 8 months ago (2014-04-03 20:39:55 UTC) #2
oshima
6 years, 8 months ago (2014-04-03 20:48:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r261520 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698