Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: src/hydrogen.cc

Issue 220813003: Add stack overflow check for inlined property getter (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-inline-getter-near-stack-limit.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 24c2ab40b64445905df381b9213a3e8695b97b36..25cb86ac9ea1ce003403e56e5f9645aff2aa2618 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -5647,7 +5647,7 @@ HInstruction* HOptimizedGraphBuilder::BuildMonomorphicAccess(
? TryInlineGetter(info->accessor(), info->map(), ast_id, return_id)
: TryInlineSetter(
info->accessor(), info->map(), ast_id, return_id, value);
- if (success) return NULL;
+ if (success || HasStackOverflow()) return NULL;
}
PushArgumentsFromEnvironment(argument_count);
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-inline-getter-near-stack-limit.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698