Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 220813003: Add stack overflow check for inlined property getter (Closed)

Created:
6 years, 8 months ago by Jarin
Modified:
6 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Add stack overflow check for inlined property getter We should check for overflow for each inlined property getter; otherwise, we can get an overflow from inlining property getter while still having pending overflow exception from some previous inlined getter (in the same polymorphic access). R=verwaest@chromium.org TEST=test/mjsunit/regress/regress-inline-getter-near-stack-limit.js Committed: https://code.google.com/p/v8/source/detail?r=20588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-inline-getter-near-stack-limit.js View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
6 years, 8 months ago (2014-04-01 11:39:42 UTC) #1
Toon Verwaest
lgtm re the fix, however, could we statically guarantee somehow that we check for StackOverflow? ...
6 years, 8 months ago (2014-04-03 11:44:33 UTC) #2
Jarin
6 years, 8 months ago (2014-04-09 07:35:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20588 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698