Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2208113002: Fix MenuPreTargetHandler Crash (Closed)

Created:
4 years, 4 months ago by jonross
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MenuPreTargetHandler Crash Apparently StatusIconWin runs a menu without providing a widget. MenuPreTargetHandler had assumed there would always be a widget to listen to. This change updates that to not attempt to listen when there is no widget. TEST=MenuControllerTest.RunWithoutWidgetDoesntCrash BUG=633897 Committed: https://crrev.com/e1038c1c30e9ec9e5cbb08b3f34eb6635c230696 Cr-Commit-Position: refs/heads/master@{#409648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M ui/views/controls/menu/menu_controller_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_pre_target_handler.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jonross
Sky@ could you take a look at this change? It addresses a crash that was ...
4 years, 4 months ago (2016-08-03 19:50:25 UTC) #2
sky
LGTM
4 years, 4 months ago (2016-08-03 21:30:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208113002/1
4 years, 4 months ago (2016-08-03 21:41:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 22:49:40 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 22:51:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1038c1c30e9ec9e5cbb08b3f34eb6635c230696
Cr-Commit-Position: refs/heads/master@{#409648}

Powered by Google App Engine
This is Rietveld 408576698