content/browser/renderer_host/text_input_manager.h - Issue 2208093004: Use focused RenderWidgetHostImpl instead of TextInputManager::GetActiveWidget() to obtain TextSelec…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/text_input_manager.h

Issue 2208093004: Use focused RenderWidgetHostImpl instead of TextInputManager::GetActiveWidget() to obtain TextSelec… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed some crashes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_view_base.h ('K') | « content/browser/renderer_host/render_widget_host_view_base.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/text_input_manager.h

diff --git a/content/browser/renderer_host/text_input_manager.h b/content/browser/renderer_host/text_input_manager.h

index b09ae5069420f5c96af8b022c118a5a5e52fc008..d3040c6aa5f878969e249fd479bc01e71c07c4b0 100644

--- a/content/browser/renderer_host/text_input_manager.h

+++ b/content/browser/renderer_host/text_input_manager.h

@@ -106,6 +106,7 @@ class CONTENT_EXPORT TextInputManager {

// The following method returns the text selection state for the given |view|.

// If |view| == nullptr, it will assume |active_view_| and return its state.

// In the case of |active_view_| == nullptr, the method will return nullptr.

+ // This method will not return nullptr when |view| != nullptr.

const TextSelection* GetTextSelection(

RenderWidgetHostViewBase* view = nullptr) const;