Use focused RenderWidgetHostImpl instead of TextInputManager::GetActiveWidget() to obtain TextSelec…

content/browser/renderer_host/render_widget_host_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include <set>
 #include <utility>
 
 #include "base/auto_reset.h"
@@ skipping 3005 matching lines @@
     TextInputManager* text_input_manager,
     RenderWidgetHostViewBase* updated_view) {
   if (GetInputMethod())
     GetInputMethod()->OnCaretBoundsChanged(this);
 }
 
 void RenderWidgetHostViewAura::OnTextSelectionChanged(
     TextInputManager* text_input_manager,
     RenderWidgetHostViewBase* updated_view) {
 #if defined(USE_X11) && !defined(OS_CHROMEOS)
-  if (!GetTextInputManager() || !GetTextInputManager()->GetActiveWidget())
+  if (!GetTextInputManager())
     return;
 
-  const TextInputManager::TextSelection* text_selection =
-      GetTextInputManager()->GetTextSelection();
+  const TextInputManager::TextSelection* text_selection = nullptr;
+  if (is_guest_view_hack_) {
+    // We obtain the TextSelection from focused RWH which is obtained from the
+    // frame tree. BrowserPlugin-based guests' RWH is not part of the frame tree
+    // and the focused RWH will be that of the embedder which is incorrect. In
+    // this case we should use TextSelection for |this| since RWHV for guest
+    // forwards text selection information to its platform view.
+    text_selection = GetTextInputManager()->GetTextSelection(this);
+  } else {
+    RenderWidgetHostViewBase* focused =
+        host_->delegate()->GetFocusedRenderWidgetHost(host_)->GetView();

[kenrb, 2016/08/08 20:45:03]

It looks like GetFocusedRenderWidgetHost can return nullptr, which means that
has to be checked.

[EhsanK, 2016/08/08 21:15:52]

Acknowledged. And Done. Thanks for spotting this.

+    if (focused)
+      text_selection = GetTextInputManager()->GetTextSelection(focused);
+  }
+
+  if (!text_selection)
+    return;
 
   if (text_selection->text.empty() || text_selection->range.is_empty())
     return;
   size_t pos = text_selection->range.GetMin() - text_selection->offset;
   size_t n = text_selection->range.length();
 
   DCHECK(pos + n <= text_selection->text.length())
       << "The text can not fully cover range.";
   if (pos >= text_selection->text.length()) {
     NOTREACHED() << "The text can not cover range.";
     return;
   }
 
   // Set the CLIPBOARD_TYPE_SELECTION to the ui::Clipboard.
   ui::ScopedClipboardWriter clipboard_writer(ui::CLIPBOARD_TYPE_SELECTION);
   clipboard_writer.WriteText(text_selection->text.substr(pos, n));
 #endif  // defined(USE_X11) && !defined(OS_CHROMEOS)
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // RenderWidgetHostViewBase, public:
 
 // static
 void RenderWidgetHostViewBase::GetDefaultScreenInfo(WebScreenInfo* results) {
   GetScreenInfoForWindow(results, NULL);
 }
 
 }  // namespace content