Make base_unittests pass in gn/win/asan builds.

Make base_unittests pass in gn/win/asan builds.

Before this, ScopedHandleTest.MultiProcess would fail because
scoped_handle_test_dll.dll got linked against clang_rt.asan-i386.lib
instead of clang_rt.asan_dll_thunk-i386.lib.  This now works.

BUG=598761
Committed: https://crrev.com/1519f9727ddc675a9e3e1de9b904ef03c7d5b831
Cr-Commit-Position: refs/heads/master@{#409662}

[Nico, 2016-08-03 22:09:05]

thakis@chromium.org changed reviewers:
+ rnk@chromium.org

[Nico, 2016-08-03 22:09:06]

With pinned clang, everything I tried (static build only so far) seemed to work
fine locally with this. (I haven't tried many things yet.)

[Nico, 2016-08-03 22:11:29]

Please look at patch set 2, ps1 accidentally included
https://codereview.chromium.org/2200183005/ as well

[Nico, 2016-08-03 22:12:01]

Description was changed from

==========
Make base_unittests pass in gn/win/asan builds.

Before this, ScopedHandleTest.MultiProcess would fail because
scoped_handle_test_dll.dll got linked against clang_rt.asan-i386.lib
instead of clang_rt.asan_dll_thunk-i386.lib.  This now works.

BUG=598671
==========

to

==========
Make base_unittests pass in gn/win/asan builds.

Before this, ScopedHandleTest.MultiProcess would fail because
scoped_handle_test_dll.dll got linked against clang_rt.asan-i386.lib
instead of clang_rt.asan_dll_thunk-i386.lib.  This now works.

BUG=598761
==========

[Dirk Pranke, 2016-08-03 22:13:19]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-08-03 22:13:20]

lgtm

https://codereview.chromium.org/2208093003/diff/20001/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/2208093003/diff/20001/build/config/BUILD.gn#n...
build/config/BUILD.gn:411: configs += [
"//build/config/sanitizers:asan_link_executable" ]
nit: can we avoid having "asan" in the names of the configs?

[Nico, 2016-08-03 22:16:42]

Thanks!

https://codereview.chromium.org/2208093003/diff/20001/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/2208093003/diff/20001/build/config/BUILD.gn#n...
build/config/BUILD.gn:411: configs += [
"//build/config/sanitizers:asan_link_executable" ]
On 2016/08/03 22:13:19, Dirk Pranke wrote:
> nit: can we avoid having "asan" in the names of the configs?

Sure, done.

Out of curiosity: WHy? It an asan-specific config; why should asan not be in the
name? Because it could be non-asan-specific in the future?

[Nico, 2016-08-03 22:17:03]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-08-03 22:17:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2208093003/#ps40001
(title: "dpranke nit")

[commit-bot: I haz the power, 2016-08-03 22:17:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[etienneb, 2016-08-03 22:20:42]

etienneb@chromium.org changed reviewers:
+ etienneb@chromium.org

[etienneb, 2016-08-03 22:20:43]

lgtm

[Dirk Pranke, 2016-08-03 22:27:34]

https://codereview.chromium.org/2208093003/diff/20001/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/2208093003/diff/20001/build/config/BUILD.gn#n...
build/config/BUILD.gn:411: configs += [
"//build/config/sanitizers:asan_link_executable" ]
On 2016/08/03 22:16:42, Nico wrote:
> On 2016/08/03 22:13:19, Dirk Pranke wrote:
> > nit: can we avoid having "asan" in the names of the configs?
> 
> Sure, done.
> 
> Out of curiosity: WHy? It an asan-specific config; why should asan not be in
the
> name? Because it could be non-asan-specific in the future?

Yes, or there might be multiple things that need to be added depending on the
combination of sanitizer flags (asan vs. asan + lsan, etc.) and I don't want to
have to add multiple configs here, just expose a single "sanitizer" config that
does everything internally.

[Reid Kleckner, 2016-08-03 22:40:19]

lgtm

Thanks!

[commit-bot: I haz the power, 2016-08-03 23:34:37]

Description was changed from

==========
Make base_unittests pass in gn/win/asan builds.

Before this, ScopedHandleTest.MultiProcess would fail because
scoped_handle_test_dll.dll got linked against clang_rt.asan-i386.lib
instead of clang_rt.asan_dll_thunk-i386.lib.  This now works.

BUG=598761
==========

to

==========
Make base_unittests pass in gn/win/asan builds.

Before this, ScopedHandleTest.MultiProcess would fail because
scoped_handle_test_dll.dll got linked against clang_rt.asan-i386.lib
instead of clang_rt.asan_dll_thunk-i386.lib.  This now works.

BUG=598761
==========

[commit-bot: I haz the power, 2016-08-03 23:34:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-03 23:36:09]

Description was changed from

==========
Make base_unittests pass in gn/win/asan builds.

Before this, ScopedHandleTest.MultiProcess would fail because
scoped_handle_test_dll.dll got linked against clang_rt.asan-i386.lib
instead of clang_rt.asan_dll_thunk-i386.lib.  This now works.

BUG=598761
==========

to

==========
Make base_unittests pass in gn/win/asan builds.

Before this, ScopedHandleTest.MultiProcess would fail because
scoped_handle_test_dll.dll got linked against clang_rt.asan-i386.lib
instead of clang_rt.asan_dll_thunk-i386.lib.  This now works.

BUG=598761

Committed: https://crrev.com/1519f9727ddc675a9e3e1de9b904ef03c7d5b831
Cr-Commit-Position: refs/heads/master@{#409662}
==========

[commit-bot: I haz the power, 2016-08-03 23:36:10]

Patchset 3 (id:??) landed as
https://crrev.com/1519f9727ddc675a9e3e1de9b904ef03c7d5b831
Cr-Commit-Position: refs/heads/master@{#409662}