Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 2208073003: PPC/s390: Clear exceptions in Invoke instead of JSEntryStub (Closed)

Created:
4 years, 4 months ago by JaideepBajwa
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Clear exceptions in Invoke instead of JSEntryStub Port cdae865436aa1039154c86baaac98b2b8a118376 Original commit message: A corresponding flag was added as well to help us find out what breaks when we do not clear pending exceptions on each JS entry. R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=5259 LOG=N Committed: https://crrev.com/31554f5b031276efcfb1db458f46c732df73f53d Cr-Commit-Position: refs/heads/master@{#38312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 4 months ago (2016-08-03 17:38:00 UTC) #1
JoranSiu
On 2016/08/03 17:38:00, JaideepBajwa wrote: > PTAL lgtm
4 years, 4 months ago (2016-08-03 17:49:39 UTC) #2
john.yan
lgtm
4 years, 4 months ago (2016-08-03 18:00:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208073003/1
4 years, 4 months ago (2016-08-03 18:02:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 18:21:33 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 18:25:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31554f5b031276efcfb1db458f46c732df73f53d
Cr-Commit-Position: refs/heads/master@{#38312}

Powered by Google App Engine
This is Rietveld 408576698