Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: content/common/ssl_status_serialization.cc

Issue 2208073002: DO NOT REVIEW: Certificate Transparency: Extend SCT verify result enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CT: Formatting and compilation fixes. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/ssl_status_serialization.h" 5 #include "content/common/ssl_status_serialization.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/numerics/safe_conversions.h" 10 #include "base/numerics/safe_conversions.h"
(...skipping 21 matching lines...) Expand all
32 32
33 std::string SerializeSecurityInfo(const SSLStatus& ssl_status) { 33 std::string SerializeSecurityInfo(const SSLStatus& ssl_status) {
34 base::Pickle pickle; 34 base::Pickle pickle;
35 pickle.WriteInt(ssl_status.security_style); 35 pickle.WriteInt(ssl_status.security_style);
36 pickle.WriteInt(ssl_status.cert_id); 36 pickle.WriteInt(ssl_status.cert_id);
37 pickle.WriteUInt32(ssl_status.cert_status); 37 pickle.WriteUInt32(ssl_status.cert_status);
38 pickle.WriteInt(ssl_status.security_bits); 38 pickle.WriteInt(ssl_status.security_bits);
39 pickle.WriteInt(ssl_status.key_exchange_info); 39 pickle.WriteInt(ssl_status.key_exchange_info);
40 pickle.WriteInt(ssl_status.connection_status); 40 pickle.WriteInt(ssl_status.connection_status);
41 pickle.WriteUInt32(ssl_status.num_unknown_scts); 41 pickle.WriteUInt32(ssl_status.num_unknown_scts);
42 pickle.WriteUInt32(ssl_status.num_invalid_scts); 42 pickle.WriteUInt32(ssl_status.num_scts_invalid_signature);
43 pickle.WriteUInt32(ssl_status.num_scts_invalid_timestamp);
43 pickle.WriteUInt32(ssl_status.num_valid_scts); 44 pickle.WriteUInt32(ssl_status.num_valid_scts);
44 pickle.WriteBool(ssl_status.pkp_bypassed); 45 pickle.WriteBool(ssl_status.pkp_bypassed);
45 return std::string(static_cast<const char*>(pickle.data()), pickle.size()); 46 return std::string(static_cast<const char*>(pickle.data()), pickle.size());
46 } 47 }
47 48
48 bool DeserializeSecurityInfo(const std::string& state, SSLStatus* ssl_status) { 49 bool DeserializeSecurityInfo(const std::string& state, SSLStatus* ssl_status) {
49 *ssl_status = SSLStatus(); 50 *ssl_status = SSLStatus();
50 51
51 if (state.empty()) { 52 if (state.empty()) {
52 // No SSL used. 53 // No SSL used.
53 return true; 54 return true;
54 } 55 }
55 56
56 base::Pickle pickle(state.data(), base::checked_cast<int>(state.size())); 57 base::Pickle pickle(state.data(), base::checked_cast<int>(state.size()));
57 base::PickleIterator iter(pickle); 58 base::PickleIterator iter(pickle);
58 int security_style; 59 int security_style;
59 if (!iter.ReadInt(&security_style) || !iter.ReadInt(&ssl_status->cert_id) || 60 if (!iter.ReadInt(&security_style) || !iter.ReadInt(&ssl_status->cert_id) ||
60 !iter.ReadUInt32(&ssl_status->cert_status) || 61 !iter.ReadUInt32(&ssl_status->cert_status) ||
61 !iter.ReadInt(&ssl_status->security_bits) || 62 !iter.ReadInt(&ssl_status->security_bits) ||
62 !iter.ReadInt(&ssl_status->key_exchange_info) || 63 !iter.ReadInt(&ssl_status->key_exchange_info) ||
63 !iter.ReadInt(&ssl_status->connection_status) || 64 !iter.ReadInt(&ssl_status->connection_status) ||
64 !iter.ReadUInt32(&ssl_status->num_unknown_scts) || 65 !iter.ReadUInt32(&ssl_status->num_unknown_scts) ||
65 !iter.ReadUInt32(&ssl_status->num_invalid_scts) || 66 !iter.ReadUInt32(&ssl_status->num_scts_invalid_signature) ||
67 !iter.ReadUInt32(&ssl_status->num_scts_invalid_timestamp) ||
66 !iter.ReadUInt32(&ssl_status->num_valid_scts) || 68 !iter.ReadUInt32(&ssl_status->num_valid_scts) ||
67 !iter.ReadBool(&ssl_status->pkp_bypassed)) { 69 !iter.ReadBool(&ssl_status->pkp_bypassed)) {
68 *ssl_status = SSLStatus(); 70 *ssl_status = SSLStatus();
69 return false; 71 return false;
70 } 72 }
71 73
72 if (!CheckSecurityStyle(security_style)) { 74 if (!CheckSecurityStyle(security_style)) {
73 *ssl_status = SSLStatus(); 75 *ssl_status = SSLStatus();
74 return false; 76 return false;
75 } 77 }
76 78
77 ssl_status->security_style = static_cast<SecurityStyle>(security_style); 79 ssl_status->security_style = static_cast<SecurityStyle>(security_style);
78 80
79 // Sanity check |security_bits|: the only allowed negative value is -1. 81 // Sanity check |security_bits|: the only allowed negative value is -1.
80 if (ssl_status->security_bits < -1) { 82 if (ssl_status->security_bits < -1) {
81 *ssl_status = SSLStatus(); 83 *ssl_status = SSLStatus();
82 return false; 84 return false;
83 } 85 }
84 86
85 // Sanity check |key_exchange_info|: 0 or greater. 87 // Sanity check |key_exchange_info|: 0 or greater.
86 if (ssl_status->key_exchange_info < 0) { 88 if (ssl_status->key_exchange_info < 0) {
87 *ssl_status = SSLStatus(); 89 *ssl_status = SSLStatus();
88 return false; 90 return false;
89 } 91 }
90 92
91 return true; 93 return true;
92 } 94 }
93 95
94 } // namespace content 96 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698