SDK implementations based on file_system rather than java_io

SDK implementations based on file_system rather than java_io

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/e2f74fc0a3c4a1caaf196939c66d65e730e82dac

[Brian Wilkerson, 2016-08-03 14:43:29]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2016-08-03 14:43:30]

This doesn't include any changes to switch over to the new implementation.

[scheglov, 2016-08-03 15:54:52]

lgtm

https://codereview.chromium.org/2207953002/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/sdk/sdk.dart (right):

https://codereview.chromium.org/2207953002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/sdk/sdk.dart:169: int index =
libraryPath.lastIndexOf(pathos.separator);
Do we have tests for this code?
I was not able to find them for AbstractSdk in sdk_io.

I think we should use resourceProvider.pathContext.separator here.

https://codereview.chromium.org/2207953002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/sdk/sdk.dart:395: //  static String
_DEFAULT_DIRECTORY_PROPERTY_NAME = "com.google.dart.sdk";
Did you want to remove this code, or you will need it for the next steps?

[Brian Wilkerson, 2016-08-03 17:16:11]

ptal

https://codereview.chromium.org/2207953002/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/sdk/sdk.dart (right):

https://codereview.chromium.org/2207953002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/sdk/sdk.dart:169: int index =
libraryPath.lastIndexOf(pathos.separator);
> Do we have tests for this code?

No. This method is overridden by both of the subclasses, so it can't be
executed. Perhaps I should just make it an abstract class (except for the TODO).

> I think we should use resourceProvider.pathContext.separator here.

Done, here and elsewhere.

https://codereview.chromium.org/2207953002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/sdk/sdk.dart:395: //  static String
_DEFAULT_DIRECTORY_PROPERTY_NAME = "com.google.dart.sdk";
> Did you want to remove this code, or you will need it for the next steps?

I think I can remove it because I think that I can get it back if I need it.
Done.

[scheglov, 2016-08-03 17:19:27]

LGTM

[Brian Wilkerson, 2016-08-03 17:25:24]

Description was changed from

==========
SDK implementations based on file_system rather than java_io
==========

to

==========
SDK implementations based on file_system rather than java_io

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e2f74fc0a3c4a1caaf196939c66d65e730e82dac
==========

[Brian Wilkerson, 2016-08-03 17:25:25]

Committed patchset #3 (id:40001) manually as
e2f74fc0a3c4a1caaf196939c66d65e730e82dac (presubmit successful).