Fix compilation failure when v8 is compiled with Chromium using GYP.

Fix compilation failure when v8 is compiled with Chromium using GYP.

Compilation breaks when compiling v8 through Chromium using GYP. The isssue
started to appear after https://codereview.chromium.org/2190973003 landed.
It happens because trace_event_common.h header is on different location if we
are compiling v8 through Chromium compared to when we are compiling v8 standalone.

BUG=

Committed: https://crrev.com/d6b62dc4defdecd60468626e6a6bb04e0470bb25
Cr-Commit-Position: refs/heads/master@{#38333}

[ivica.bogosavljevic, 2016-08-03 14:24:13]

ivica.bogosavljevic@imgtec.com changed reviewers:
+ jochen@chromium.org, machenbach@chromium.org, milko.leporis@imgtec.com,
mtrofin@chromium.org, rskang@google.com

[ivica.bogosavljevic, 2016-08-03 14:24:14]

PTAL

V8 compilation fails with following error if v8 is compiled with Chromium using
GYP: 

[46/24333] CXX obj.host/v8/src/libplatform/tracing/v8_libplatform.trace-writer.o
FAILED: obj.host/v8/src/libplatform/tracing/v8_libplatform.trace-writer.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj.host/v8/src/libplatform/tracing/v8_libplatform.trace-writer.o.d
-DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD
-DCR_CLANG_REVISION=274369-1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1
-DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1
-DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1
-DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS -DUSE_UDEV
-DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
-DENABLE_PDF=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
-DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1
-DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
-DSAFE_BROWSING_DB_LOCAL -DV8_TARGET_ARCH_MIPS -DCAN_USE_FPU_INSTRUCTIONS
-D__mips_hard_float=1 -DV8_I18N_SUPPORT -DUSE_LIBPCI=1 -DUSE_GLIB=1
-DUSE_NSS_CERTS=1 -D_MIPS_TARGET_HW -D_MIPS_ARCH_MIPS32R2 -DFPU_MODE_FP32
-DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DENABLE_HANDLE_ZAPPING
-I../../v8 -I../../v8/include -Igen -fstack-protector --param=ssp-buffer-size=4 
-pthread -fno-strict-aliasing -Wall -Wno-unused-parameter
-Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC
-fcolor-diagnostics -Xclang -load -Xclang
/home/v8mips/Buildbot/Setup/Slave-CHROMIUM-linux/build_and_test_chromium_with_pnacl/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -Xclang
-plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang
-plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -Xclang
-plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene
-Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template
-Wno-nonportable-include-path -Wno-unused-variable -m32 -fno-ident
-fdata-sections -ffunction-sections -funwind-tables -fdata-sections
-ffunction-sections -O3 -fno-exceptions -fno-rtti -fno-threadsafe-statics
-fvisibility-inlines-hidden -std=gnu++11 -Wno-deprecated  -c
../../v8/src/libplatform/tracing/trace-writer.cc -o
obj.host/v8/src/libplatform/tracing/v8_libplatform.trace-writer.o
../../v8/src/libplatform/tracing/trace-writer.cc:9:10: fatal error:
'base/trace_event/common/trace_event_common.h' file not found
#include "base/trace_event/common/trace_event_common.h"

[jochen (gone - plz use gerrit), 2016-08-03 14:51:04]

lgtm

can you add yourself to the AUTHORS file please?

[ivica.bogosavljevic, 2016-08-04 06:26:03]

On 2016/08/03 14:51:04, jochen wrote:
> lgtm
> 
> can you add yourself to the AUTHORS file please?

I am already added to AUTHORS as part of Imagination technologies
Imagination Technologies, LLC <*@imgtec.com>

Is this enough?

[jochen (gone - plz use gerrit), 2016-08-04 06:36:57]

On 2016/08/04 at 06:26:11, ivica.bogosavljevic wrote:
> 

Yes

[ivica.bogosavljevic, 2016-08-04 08:39:16]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com

[commit-bot: I haz the power, 2016-08-04 08:39:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 09:11:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-04 09:12:41]

Description was changed from

==========
Fix compilation failure when v8 is compiled with Chromium using GYP.

Compilation breaks when compiling v8 through Chromium using GYP. The isssue
started to appear after https://codereview.chromium.org/2190973003 landed.
It happens because trace_event_common.h header is on different location if we
are compiling v8 through Chromium compared to when we are compiling v8
standalone.

BUG=
==========

to

==========
Fix compilation failure when v8 is compiled with Chromium using GYP.

Compilation breaks when compiling v8 through Chromium using GYP. The isssue
started to appear after https://codereview.chromium.org/2190973003 landed.
It happens because trace_event_common.h header is on different location if we
are compiling v8 through Chromium compared to when we are compiling v8
standalone.

BUG=

Committed: https://crrev.com/d6b62dc4defdecd60468626e6a6bb04e0470bb25
Cr-Commit-Position: refs/heads/master@{#38333}
==========

[commit-bot: I haz the power, 2016-08-04 09:12:42]

Patchset 1 (id:??) landed as
https://crrev.com/d6b62dc4defdecd60468626e6a6bb04e0470bb25
Cr-Commit-Position: refs/heads/master@{#38333}