Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2207933002: Reland of Separate deferred startup into tasks. (Closed)

Created:
4 years, 4 months ago by Peter Wen
Modified:
4 years, 4 months ago
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, asvitkine+watch_chromium.org, Yaron, Ted C
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Separate deferred startup into tasks. Original: https://codereview.chromium.org/2121863002/ Fixes: - Guarantee ChromeApplication#onStartWithNative has been called by custom tabs before posting deferred startup. BUG=614452 TBR=dtrainor@chromium.org,agrieve@chromium.org,asvitkine@chromium.org,pasko@chromium.org Committed: https://crrev.com/bcdc694e5fb4cf003124cf5b940e4807322a184e Cr-Commit-Position: refs/heads/master@{#410342}

Patch Set 1 : Original CL #

Patch Set 2 : Move postDeferredStartupIfNeeded to onStartWithNative #

Total comments: 2

Patch Set 3 : Fix one-line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -157 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 2 6 chunks +45 lines, -48 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 1 2 2 chunks +49 lines, -25 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 2 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 8 chunks +145 lines, -55 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaUtils.java View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java View 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/FullscreenTestUtils.java View 2 chunks +3 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 8 chunks +70 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Peter Wen
Hi Yusuf, Can you take a look at the fix for custom tabs test failure? ...
4 years, 4 months ago (2016-08-03 14:08:43 UTC) #3
Peter Wen
cc: yfriedman@ and tedchoc@ for original CL and revert.
4 years, 4 months ago (2016-08-03 14:09:34 UTC) #6
Alexei Svitkine (slow)
lgtm
4 years, 4 months ago (2016-08-03 14:57:07 UTC) #7
Yusuf
lgtm https://codereview.chromium.org/2207933002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java (right): https://codereview.chromium.org/2207933002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java#newcode482 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:482: if (mHasCreatedTabEarly && !mMainTab.isLoading()) { I think this ...
4 years, 4 months ago (2016-08-03 17:22:22 UTC) #10
David Trainor- moved to gerrit
rubber stamp lgtm on chrome/android from previous CL.
4 years, 4 months ago (2016-08-04 16:06:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207933002/40001
4 years, 4 months ago (2016-08-08 12:45:57 UTC) #14
Peter Wen
Thanks for the reviews! https://codereview.chromium.org/2207933002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java (right): https://codereview.chromium.org/2207933002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java#newcode482 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:482: if (mHasCreatedTabEarly && !mMainTab.isLoading()) { ...
4 years, 4 months ago (2016-08-08 12:46:01 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-08 13:52:22 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 13:54:00 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bcdc694e5fb4cf003124cf5b940e4807322a184e
Cr-Commit-Position: refs/heads/master@{#410342}

Powered by Google App Engine
This is Rietveld 408576698