Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2207923002: Properly handle exceptions in cctests (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Properly handle exceptions in cctests Thrown exceptions must be handled before another exception is thrown. This fixes all remaining test failures exposed by not clearing pending exceptions in JSEntryStub. BUG=v8:5259 Committed: https://crrev.com/a53d46874780b11f36bb4bf16bdbf1461e44fcf5 Cr-Commit-Position: refs/heads/master@{#38324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M test/cctest/test-parsing.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M test/fuzzer/regexp.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
jgruber
4 years, 4 months ago (2016-08-03 14:00:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207923002/1
4 years, 4 months ago (2016-08-03 15:01:30 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-03 15:01:31 UTC) #10
Yang
lgtm
4 years, 4 months ago (2016-08-04 06:28:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207923002/1
4 years, 4 months ago (2016-08-04 07:12:42 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 07:20:27 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 07:22:23 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a53d46874780b11f36bb4bf16bdbf1461e44fcf5
Cr-Commit-Position: refs/heads/master@{#38324}

Powered by Google App Engine
This is Rietveld 408576698