Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 4 months ago by jgruber Modified:
4 years, 4 months ago Reviewers:
Yang CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionProperly handle exceptions in cctests
Thrown exceptions must be handled before another exception is thrown.
This fixes all remaining test failures exposed by not clearing pending
exceptions in JSEntryStub.
BUG=v8:5259
Committed: https://crrev.com/a53d46874780b11f36bb4bf16bdbf1461e44fcf5
Cr-Commit-Position: refs/heads/master@{#38324}
Patch Set 1 #
Created: 4 years, 4 months ago
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jgruber@chromium.org changed reviewers: + yangguo@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jgruber@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Properly handle exceptions in cctests Thrown exceptions must be handled before another exception is thrown. This fixes all remaining test failures exposed by not clearing pending exceptions in JSEntryStub. BUG=5259 ========== to ========== Properly handle exceptions in cctests Thrown exceptions must be handled before another exception is thrown. This fixes all remaining test failures exposed by not clearing pending exceptions in JSEntryStub. BUG=v8:5259 ==========
lgtm
The CQ bit was checked by jgruber@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Properly handle exceptions in cctests Thrown exceptions must be handled before another exception is thrown. This fixes all remaining test failures exposed by not clearing pending exceptions in JSEntryStub. BUG=v8:5259 ========== to ========== Properly handle exceptions in cctests Thrown exceptions must be handled before another exception is thrown. This fixes all remaining test failures exposed by not clearing pending exceptions in JSEntryStub. BUG=v8:5259 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Properly handle exceptions in cctests Thrown exceptions must be handled before another exception is thrown. This fixes all remaining test failures exposed by not clearing pending exceptions in JSEntryStub. BUG=v8:5259 ========== to ========== Properly handle exceptions in cctests Thrown exceptions must be handled before another exception is thrown. This fixes all remaining test failures exposed by not clearing pending exceptions in JSEntryStub. BUG=v8:5259 Committed: https://crrev.com/a53d46874780b11f36bb4bf16bdbf1461e44fcf5 Cr-Commit-Position: refs/heads/master@{#38324} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a53d46874780b11f36bb4bf16bdbf1461e44fcf5 Cr-Commit-Position: refs/heads/master@{#38324} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
