Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: runtime/vm/regexp.cc

Issue 2207883004: From Regis: Remove regexp pattern from function name to avoid crash in debug mode. Fix service obj… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/test_helper.dart ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/regexp.cc
diff --git a/runtime/vm/regexp.cc b/runtime/vm/regexp.cc
index f119a256fb00ba6e7c80a278aaed515ecce380dc..9edfbf6a7ac66202c4934dade4b375750a8e4309 100644
--- a/runtime/vm/regexp.cc
+++ b/runtime/vm/regexp.cc
@@ -5251,13 +5251,7 @@ static void CreateSpecializedFunction(Thread* thread, Zone* zone,
const intptr_t kParamCount = RegExpMacroAssembler::kParamCount;
Function& fn = Function::Handle(zone, Function::New(
- // Append the regexp pattern to the function name.
- String::Handle(zone, Symbols::New(thread,
- String::Handle(zone, String::Concat(
- String::Handle(zone, String::Concat(
- Symbols::ColonMatcher(),
- Symbols::ColonSpace(), Heap::kOld)),
- String::Handle(regexp.pattern()), Heap::kOld)))),
+ Symbols::ColonMatcher(),
RawFunction::kIrregexpFunction,
true, // Static.
false, // Not const.
« no previous file with comments | « runtime/observatory/tests/service/test_helper.dart ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698