Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2207883004: From Regis: Remove regexp pattern from function name to avoid crash in debug mode. Fix service obj… (Closed)

Created:
4 years, 4 months ago by turnidge
Modified:
4 years, 4 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

From Regis: Remove regexp pattern from function name to avoid crash in debug mode. Fix service object to properly support regexp. Add regression test. (Review by Todd) From Todd: Fix a problem in caching that Regis's change discovered in the Observatory. (Review by Regis) From Ryan: Added teest. BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/4bcc85e37e81595c81fc2252519d5593a4bd8bf9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -36 lines) Patch
M runtime/observatory/lib/src/service/object.dart View 16 chunks +9 lines, -28 lines 0 comments Download
A runtime/observatory/tests/service/regexp_function_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/regexp.cc View 1 chunk +1 line, -7 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
turnidge
4 years, 4 months ago (2016-08-03 21:21:38 UTC) #2
regis
LGTM Thanks to Ryan for the test and to you for the caching fix!
4 years, 4 months ago (2016-08-03 21:29:01 UTC) #3
turnidge
4 years, 4 months ago (2016-08-03 22:24:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4bcc85e37e81595c81fc2252519d5593a4bd8bf9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698