Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2207883002: Remove "!IsSearchResultsPage" check in ChromeOmniboxClient (Closed)

Created:
4 years, 4 months ago by Marc Treib
Modified:
4 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_prefetch_srp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "!IsSearchResultsPage" check in ChromeOmniboxClient IsSearchResultsPage is always false here in practice. Follow-up to https://codereview.chromium.org/2143953002 BUG=627747 Committed: https://crrev.com/ba5087e47fc4b2553050c4bd2eab6f74bed056ed Cr-Commit-Position: refs/heads/master@{#409746}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -15 lines) Patch
M chrome/browser/ui/omnibox/chrome_omnibox_client.h View 1 chunk +0 lines, -4 lines 1 comment Download
M chrome/browser/ui/omnibox/chrome_omnibox_client.cc View 1 chunk +4 lines, -11 lines 0 comments Download

Depends on Patchset:

Issue 2143953002 Patch 40001

Messages

Total messages: 10 (5 generated)
Marc Treib
The promised follow-up - PTAL! https://codereview.chromium.org/2207883002/diff/1/chrome/browser/ui/omnibox/chrome_omnibox_client.h File chrome/browser/ui/omnibox/chrome_omnibox_client.h (left): https://codereview.chromium.org/2207883002/diff/1/chrome/browser/ui/omnibox/chrome_omnibox_client.h#oldcode20 chrome/browser/ui/omnibox/chrome_omnibox_client.h:20: class NavigationController; unrelated - ...
4 years, 4 months ago (2016-08-03 10:22:41 UTC) #3
Peter Kasting
LGTM
4 years, 4 months ago (2016-08-03 21:52:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207883002/1
4 years, 4 months ago (2016-08-04 08:21:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 09:13:23 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 09:15:33 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ba5087e47fc4b2553050c4bd2eab6f74bed056ed
Cr-Commit-Position: refs/heads/master@{#409746}

Powered by Google App Engine
This is Rietveld 408576698