Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2207873002: Remove unused includes of shell::InterfaceRegistry (Closed)

Created:
4 years, 4 months ago by hugoh_UTC2
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused includes of shell::InterfaceRegistry This is a follow-up to: https://codereview.chromium.org/2201183003/ Committed: https://crrev.com/26c57658a5b100dcf91d7453b1582c1899120f23 Cr-Commit-Position: refs/heads/master@{#409776}

Patch Set 1 #

Patch Set 2 : Unfail compilation of service_worker_version_unittest.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M content/browser/browser_child_process_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/browser_child_process_host_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/render_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/utility_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
hugoh_UTC2
Hi! PTAL at this small clean-up. I found these includes and forward declarations being left ...
4 years, 4 months ago (2016-08-03 10:24:25 UTC) #3
Ben Goodger (Google)
lgtm
4 years, 4 months ago (2016-08-03 14:19:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207873002/1
4 years, 4 months ago (2016-08-03 15:28:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/134671)
4 years, 4 months ago (2016-08-03 15:45:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207873002/20001
4 years, 4 months ago (2016-08-04 14:06:42 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 14:11:24 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 14:13:11 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26c57658a5b100dcf91d7453b1582c1899120f23
Cr-Commit-Position: refs/heads/master@{#409776}

Powered by Google App Engine
This is Rietveld 408576698