Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2207813002: Prompt for a reason when restarting a master, include that reason in the CL description. (Closed)

Created:
4 years, 4 months ago by dsansome
Modified:
4 years, 4 months ago
Reviewers:
Vadim Sh., chrishall
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Prompt for a reason when restarting a master, include that reason in the CL description. BUG=633465 Committed: https://chromium.googlesource.com/infra/infra/+/77feb10e7e49ba4827df934fa56cb37f0a964bac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M infra/tools/restart/__main__.py View 1 chunk +1 line, -1 line 0 comments Download
M infra/tools/restart/restart.py View 6 chunks +23 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
dsansome
4 years, 4 months ago (2016-08-03 05:12:45 UTC) #2
chrishall
lgtm
4 years, 4 months ago (2016-08-03 05:17:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207813002/1
4 years, 4 months ago (2016-08-03 05:19:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Infra Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3067ab68c8b45d10)
4 years, 4 months ago (2016-08-03 05:24:38 UTC) #7
dsansome
+vadimsh for OWNERS
4 years, 4 months ago (2016-08-03 05:28:29 UTC) #9
Vadim Sh.
lgtm (IMHO, providing BUG=... line is good enough reason in itself)
4 years, 4 months ago (2016-08-03 16:54:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207813002/1
4 years, 4 months ago (2016-08-05 03:33:36 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 03:47:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/77feb10e7e49ba4827df934fa56cb...

Powered by Google App Engine
This is Rietveld 408576698