Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2207763005: [Offline Pages] Revises Background OfflinerRequestStatus histogram to have namespace suffix. (Closed)

Created:
4 years, 4 months ago by dougarnett
Modified:
4 years, 4 months ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, asvitkine+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Revises Background OfflinerRequestStatus histogram to have namespace suffix. BUG=634379 Committed: https://crrev.com/2ae78495f822b49005b226b137e1844fb0c51c2b Cr-Commit-Position: refs/heads/master@{#410252}

Patch Set 1 #

Patch Set 2 : merge with download namespace change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M components/offline_pages/background/request_coordinator.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 1 5 chunks +28 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
dougarnett
Initial cut and moving the OfflinerRequestStatus histogram to having a namespace suffix. Jian, I'm wondering ...
4 years, 4 months ago (2016-08-04 17:49:27 UTC) #4
Pete Williamson
lgtm
4 years, 4 months ago (2016-08-05 23:07:24 UTC) #7
dougarnett
Steven, would you be available to review this histogram change?
4 years, 4 months ago (2016-08-05 23:21:47 UTC) #9
Steven Holte
lgtm
4 years, 4 months ago (2016-08-06 00:16:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207763005/20001
4 years, 4 months ago (2016-08-06 02:05:19 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-06 02:08:49 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-06 02:10:45 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ae78495f822b49005b226b137e1844fb0c51c2b
Cr-Commit-Position: refs/heads/master@{#410252}

Powered by Google App Engine
This is Rietveld 408576698