Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2207753003: Don't leave fResScale uninitialized when constructing an SkStroke. (Closed)

Created:
4 years, 4 months ago by Dean McNamee
Modified:
4 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git/@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't leave fResScale uninitialized when constructing an SkStroke. Set a default value of 1. Users can set it with setResScale, but it's better that the constructor doesn't just leave the field uninitialized otherwise. R=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2207753003 Committed: https://skia.googlesource.com/skia/+/bb75a951f3e51fcbdf492a3818b7ff82e81a4f73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/core/SkStroke.cpp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dean McNamee
4 years, 4 months ago (2016-08-03 12:51:05 UTC) #1
reed1
lgtm
4 years, 4 months ago (2016-08-03 12:58:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207753003/1
4 years, 4 months ago (2016-08-03 13:56:03 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 14:21:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bb75a951f3e51fcbdf492a3818b7ff82e81a4f73

Powered by Google App Engine
This is Rietveld 408576698