Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2207743002: Fix panel initial state. (Closed)

Created:
4 years, 4 months ago by David Tseng
Modified:
4 years, 4 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix panel initial state. Panel wasn't respecting ChromeVox Next state. BUG=625449 Committed: https://crrev.com/04579622a2420c29f9bea0b76b4cd2fcec0a499e Cr-Commit-Position: refs/heads/master@{#409637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
David Tseng
4 years, 4 months ago (2016-08-02 23:38:44 UTC) #4
dmazzoni
lgtm
4 years, 4 months ago (2016-08-03 20:36:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207743002/1
4 years, 4 months ago (2016-08-03 20:37:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 22:11:29 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 22:13:08 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/04579622a2420c29f9bea0b76b4cd2fcec0a499e
Cr-Commit-Position: refs/heads/master@{#409637}

Powered by Google App Engine
This is Rietveld 408576698