Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2207643005:
Workaround for warning parsing comment in idl (Closed)
|
Created:
4 years, 4 months ago by dmazzoni Modified:
4 years, 4 months ago CC:
aboxhall+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWorkaround for warning parsing comment in idl
A comment is not expected after the last enum value,
apparently...
BUG=634338
TBR=nektar@chromium.org
Committed: https://crrev.com/42ace53134381b6d6bc067ad1e96bb34daaed760
Cr-Commit-Position: refs/heads/master@{#409813}
Patch Set 1 #Patch Set 2 : Moved comments before each value #Messages
Total messages: 17 (7 generated)
Description was changed from ========== Speculative fix for comment warning parsing idl A comment is not expected after an enum value that doesn't end in a comma? BUG=634338 ========== to ========== Speculative fix for comment warning parsing idl A comment is not expected after an enum value that doesn't end in a comma? BUG=634338 TBR=nektar@chromium.org ==========
dmazzoni@chromium.org changed reviewers: + mark@chromium.org, nektar@chromium.org
The CQ bit was checked by dmazzoni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_com... [2989/11095] ACTION //ui/accessibility:ax_gen_schema_generator(//build/toolchain/mac:clang_x64) ../../ui/accessibility/ax_enums.idl(523) : Error : Unexpected "}" after comment.
The CQ bit was unchecked by dmazzoni@chromium.org
On 2016/08/04 at 16:07:34, mark wrote: > https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_com... > > [2989/11095] ACTION //ui/accessibility:ax_gen_schema_generator(//build/toolchain/mac:clang_x64) > ../../ui/accessibility/ax_enums.idl(523) : Error : Unexpected "}" after comment. Darn. OK, I'm reproducing it now too. Let me try a few more things, I'll just delete the comment if nothing works.
Description was changed from ========== Speculative fix for comment warning parsing idl A comment is not expected after an enum value that doesn't end in a comma? BUG=634338 TBR=nektar@chromium.org ========== to ========== Workaround for warning parsing comment in idl A comment is not expected after the last enum value, apparently... BUG=634338 TBR=nektar@chromium.org ==========
The CQ bit was checked by dmazzoni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
OK, moved the comments before each enum value and I'm not getting any warnings during compile now. Sorry about the noise!
That’s cool. But the idl-processing script is pretty obviously broken, maybe we should fix it too.
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Workaround for warning parsing comment in idl A comment is not expected after the last enum value, apparently... BUG=634338 TBR=nektar@chromium.org ========== to ========== Workaround for warning parsing comment in idl A comment is not expected after the last enum value, apparently... BUG=634338 TBR=nektar@chromium.org Committed: https://crrev.com/42ace53134381b6d6bc067ad1e96bb34daaed760 Cr-Commit-Position: refs/heads/master@{#409813} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/42ace53134381b6d6bc067ad1e96bb34daaed760 Cr-Commit-Position: refs/heads/master@{#409813}
Message was sent while issue was closed.
FYI, I came across this issue in the past. The IDL parser / compiler needs fixing, but I never had time to fix it. (Smile.) -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
