Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2207643003: Revert of Change wildcard source expression matching to conform latest spec (Closed)

Created:
4 years, 4 months ago by Mike West
Modified:
4 years, 4 months ago
CC:
achuith+watch_chromium.org, blink-reviews, chromium-reviews, dzhioev+watch_chromium.org, media-router+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change wildcard source expression matching to conform latest spec (patchset #5 id:80001 of https://codereview.chromium.org/2160983002/ ) Reason for revert: This breaks PDFium's handling of PDFs hosted on `file:`. Unfortunately, we didn't have tests covering this functionality, but we still need to fix it. :) Original issue's description: > Change wildcard source expression matching to conform latest spec > > This changes wildcard source expression matching to require > any schemes other than http/https/ws/wss be explicitly present > in the source list to match, per > https://w3c.github.io/webappsec-csp/#match-url-to-source-expression > > This also updates CSP injected in chrome/browser/ui/webui/ to explicitly allow > `chrome:` as in `connect-src chrome:` to fix failing tests. > > Previous CL at https://codereview.chromium.org/1973933002/ is stale, > so creating a new one to nail it this time. > BUG=611314 > R=mkwst@chromium.org > > Committed: https://crrev.com/6104167b0bf16a3520a898dbe67227637d1c214e > Cr-Commit-Position: refs/heads/master@{#408654} TBR=jochen@chromium.org,mfoltz@chromium.org,shekyan@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=611314 Committed: https://crrev.com/14f3d8cdac5f46ec73fd38e5d9d731e57966427f Cr-Commit-Position: refs/heads/master@{#409480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSourceList.cpp View 1 chunk +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSourceListTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mike West
Created Revert of Change wildcard source expression matching to conform latest spec
4 years, 4 months ago (2016-08-03 07:22:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207643003/1
4 years, 4 months ago (2016-08-03 07:22:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 08:55:49 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 08:59:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14f3d8cdac5f46ec73fd38e5d9d731e57966427f
Cr-Commit-Position: refs/heads/master@{#409480}

Powered by Google App Engine
This is Rietveld 408576698