Issue 2207643002: Narrow the scope of writable code to the forwarding phase of become instead of the whole isolate re…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2207643002: Narrow the scope of writable code to the forwarding phase of become instead of the whole isolate re… (Closed)

Created:
4 years, 4 months ago by rmacnak

Modified:
4 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Narrow the scope of writable code to the forwarding phase of become instead of the whole isolate reload scope. Other operations during an isolate reload scope may create new protected code or re-protect old code. Also, only make code writable on IA32. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/25759da7bfe581700837c36ebf07b48a3de62933

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -13 lines)			Patch
	M	runtime/vm/become.cc	View		2 chunks	+35 lines, -3 lines	0 comments	Download
	M	runtime/vm/isolate_reload.cc	View		2 chunks	+0 lines, -10 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

4 years, 4 months ago (2016-08-02 17:19:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
25759da7bfe581700837c36ebf07b48a3de62933 (presubmit successful).