Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2207593002: mac {content,app}_shell: disable Breakpad upload (Closed)

Created:
4 years, 4 months ago by Mark Mentovai
Modified:
4 years, 4 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Dirk Pranke, Peter Beverloo, jam, extensions-reviews_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac {content,app}_shell: disable Breakpad upload Breakpad upload should be disabled for these targets, but it was inadvertently enabled in bd828670eaef. BUG=626811 Committed: https://crrev.com/8ecf788aa4505ad102829a31f9160d4fef7feab0 Cr-Commit-Position: refs/heads/master@{#409228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Mark Mentovai
4 years, 4 months ago (2016-08-02 16:23:40 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 4 months ago (2016-08-02 16:26:39 UTC) #6
James Cook
lgtm
4 years, 4 months ago (2016-08-02 16:55:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207593002/1
4 years, 4 months ago (2016-08-02 17:42:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 17:46:50 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 17:48:48 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ecf788aa4505ad102829a31f9160d4fef7feab0
Cr-Commit-Position: refs/heads/master@{#409228}

Powered by Google App Engine
This is Rietveld 408576698