Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/build_command_buffer.py

Issue 2207563002: Fix build_command_buffer for Windows (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/build_command_buffer.py
diff --git a/tools/build_command_buffer.py b/tools/build_command_buffer.py
index 0349419030f56664f508f9619383ed1a967e1132..c1079867265030e4d71384ce5dc17a505e18a10d 100755
--- a/tools/build_command_buffer.py
+++ b/tools/build_command_buffer.py
@@ -135,12 +135,14 @@ def main():
sys.exit('Error (ret code: %s) calling "%s" in %s' % (
error.returncode, error.cmd, chrome_src_dir))
+ gn = 'gn'
platform = 'linux64'
if sys.platform == 'darwin':
platform = 'mac'
elif sys.platform == 'win32':
platform = 'win'
- gn = os.path.join(chrome_src_dir, 'buildtools', platform, 'gn')
+ gn = 'gn.exe'
+ gn = os.path.join(chrome_src_dir, 'buildtools', platform, gn)
try:
subprocess.check_call([gn, 'gen', chrome_target_dir_rel],
cwd=chrome_src_dir)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698