Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: src/compiler/common-operator.cc

Issue 2207533002: [turbofan] Remove IfExceptionHint from exception projections. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/common-operator.h ('k') | src/compiler/instruction-selector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/common-operator.cc
diff --git a/src/compiler/common-operator.cc b/src/compiler/common-operator.cc
index 28e5bbcb2be45a766382c5d19fdad7ec52209b2b..571775aacee330fb32b9a24226c377696d918b87 100644
--- a/src/compiler/common-operator.cc
+++ b/src/compiler/common-operator.cc
@@ -75,36 +75,6 @@ DeoptimizeParameters const& DeoptimizeParametersOf(Operator const* const op) {
return OpParameter<DeoptimizeParameters>(op);
}
-IfExceptionHint ExceptionHintFromCatchPrediction(
- HandlerTable::CatchPrediction prediction) {
- switch (prediction) {
- case HandlerTable::UNCAUGHT:
- return IfExceptionHint::kLocallyUncaught;
- case HandlerTable::CAUGHT:
- return IfExceptionHint::kLocallyCaught;
- case HandlerTable::PROMISE:
- return IfExceptionHint::kLocallyCaughtForPromiseReject;
- }
- UNREACHABLE();
- return IfExceptionHint::kLocallyUncaught;
-}
-
-size_t hash_value(IfExceptionHint hint) { return static_cast<size_t>(hint); }
-
-
-std::ostream& operator<<(std::ostream& os, IfExceptionHint hint) {
- switch (hint) {
- case IfExceptionHint::kLocallyUncaught:
- return os << "Uncaught";
- case IfExceptionHint::kLocallyCaught:
- return os << "Caught";
- case IfExceptionHint::kLocallyCaughtForPromiseReject:
- return os << "CaughtForPromiseReject";
- }
- UNREACHABLE();
- return os;
-}
-
bool operator==(SelectParameters const& lhs, SelectParameters const& rhs) {
return lhs.representation() == rhs.representation() &&
@@ -240,6 +210,7 @@ std::ostream& operator<<(std::ostream& os,
V(IfTrue, Operator::kKontrol, 0, 0, 1, 0, 0, 1) \
V(IfFalse, Operator::kKontrol, 0, 0, 1, 0, 0, 1) \
V(IfSuccess, Operator::kKontrol, 0, 0, 1, 0, 0, 1) \
+ V(IfException, Operator::kKontrol, 0, 1, 1, 1, 1, 1) \
V(IfDefault, Operator::kKontrol, 0, 0, 1, 0, 0, 1) \
V(Throw, Operator::kKontrol, 1, 1, 1, 0, 0, 1) \
V(Terminate, Operator::kKontrol, 0, 1, 1, 0, 0, 1) \
@@ -358,20 +329,6 @@ struct CommonOperatorGlobalCache final {
CACHED_OP_LIST(CACHED)
#undef CACHED
- template <IfExceptionHint kCaughtLocally>
- struct IfExceptionOperator final : public Operator1<IfExceptionHint> {
- IfExceptionOperator()
- : Operator1<IfExceptionHint>( // --
- IrOpcode::kIfException, Operator::kKontrol, // opcode
- "IfException", // name
- 0, 1, 1, 1, 1, 1, // counts
- kCaughtLocally) {} // parameter
- };
- IfExceptionOperator<IfExceptionHint::kLocallyUncaught> kIfExceptionUOperator;
- IfExceptionOperator<IfExceptionHint::kLocallyCaught> kIfExceptionCOperator;
- IfExceptionOperator<IfExceptionHint::kLocallyCaughtForPromiseReject>
- kIfExceptionPOperator;
-
template <size_t kInputCount>
struct EndOperator final : public Operator {
EndOperator()
@@ -638,19 +595,6 @@ const Operator* CommonOperatorBuilder::DeoptimizeUnless(
reason); // parameter
}
-const Operator* CommonOperatorBuilder::IfException(IfExceptionHint hint) {
- switch (hint) {
- case IfExceptionHint::kLocallyUncaught:
- return &cache_.kIfExceptionUOperator;
- case IfExceptionHint::kLocallyCaught:
- return &cache_.kIfExceptionCOperator;
- case IfExceptionHint::kLocallyCaughtForPromiseReject:
- return &cache_.kIfExceptionPOperator;
- }
- UNREACHABLE();
- return nullptr;
-}
-
const Operator* CommonOperatorBuilder::Switch(size_t control_output_count) {
return new (zone()) Operator( // --
« no previous file with comments | « src/compiler/common-operator.h ('k') | src/compiler/instruction-selector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698