chrome/browser/ui/webui/help/version_updater_win.h - Issue 2207523002: Move on-demand update checks from the FILE thread to the blocking pool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/help/version_updater_win.h

Issue 2207523002: Move on-demand update checks from the FILE thread to the blocking pool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@threadfix

Patch Set: GitCookie Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/google/google_update_win_unittest.cc ('K') | « chrome/browser/google/google_update_win_unittest.cc ('k') | chrome/browser/ui/webui/help/version_updater_win.cc » ('j') | chrome/browser/ui/webui/help/version_updater_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/help/version_updater_win.h

diff --git a/chrome/browser/ui/webui/help/version_updater_win.h b/chrome/browser/ui/webui/help/version_updater_win.h

index eab092d1002cef9e8c3f1e7662567546ef3314c4..501ea8c4302a54cee94f27b35d0c2383866bc5f0 100644

--- a/chrome/browser/ui/webui/help/version_updater_win.h

+++ b/chrome/browser/ui/webui/help/version_updater_win.h

@@ -38,7 +38,7 @@ class VersionUpdaterWin : public VersionUpdater,

const base::string16& new_version) override;

private:

- void BeginUpdateCheckOnFileThread(bool install_update_if_possible);

+ void BeginUpdateCheckInBlockingPool(bool install_update_if_possible);

// A task run on the UI thread with the result of checking for a pending

// restart.