components/ntp_snippets.gypi - Issue 2207493002: Add CategoryInfo for meta information of content suggestions Categories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets.gypi

Issue 2207493002: Add CategoryInfo for meta information of content suggestions Categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use base::Optional for ContentSuggestionsService::GetCategoryInfo Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/snippets_internals_message_handler.cc ('K') | « chrome/browser/ui/webui/snippets_internals_message_handler.cc ('k') | components/ntp_snippets/BUILD.gn » ('j') | components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets.gypi

diff --git a/components/ntp_snippets.gypi b/components/ntp_snippets.gypi

index f82920e2299953d008f088b498cc7886ab9cf7f0..27817218a1f346855a4911134b8fbc00315c8f68 100644

--- a/components/ntp_snippets.gypi

+++ b/components/ntp_snippets.gypi

@@ -13,6 +13,7 @@

'dependencies': [

'../base/base.gyp:base',

+ '../components/components_strings.gyp:components_strings',

'../google_apis/google_apis.gyp:google_apis',

'../net/net.gyp:net',

'../url/url.gyp:url_lib',

@@ -37,6 +38,8 @@

'ntp_snippets/bookmarks/bookmark_suggestions_provider.h',

'ntp_snippets/category_factory.cc',

'ntp_snippets/category_factory.h',

+ 'ntp_snippets/category_info.cc',

+ 'ntp_snippets/category_info.h',

'ntp_snippets/category_status.cc',

'ntp_snippets/category_status.h',

'ntp_snippets/category.cc',