Add CategoryInfo for meta information of content suggestions Categories

components/ntp_snippets/content_suggestions_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/content_suggestions_service.h"
 
 #include <algorithm>
 #include <iterator>
 
 #include "base/bind.h"
@@ skipping 32 matching lines @@
     return CategoryStatus::ALL_SUGGESTIONS_EXPLICITLY_DISABLED;
   }
 
   auto iterator = providers_by_category_.find(category);
   if (iterator == providers_by_category_.end())
     return CategoryStatus::NOT_PROVIDED;
 
   return iterator->second->GetCategoryStatus(category);
 }
 
+CategoryInfo ContentSuggestionsService::GetCategoryInfo(

[Marc Treib, 2016/08/08 14:11:26]

Didn't we agree on returning a base::Optional?

[Philipp Keck, 2016/08/08 14:50:18]

Done.

+    Category category) const {
+  auto iterator = providers_by_category_.find(category);
+  if (iterator == providers_by_category_.end())

[Marc Treib, 2016/08/08 14:11:26]

Braces if the body doesn't fit on one line

[Philipp Keck, 2016/08/08 14:50:18]

Done.

That's one of the many reasons why I'd always use braces everywhere...
Otherwise you do some search-and-replace and then use the formatter and 
suddenly the result of the auto-formatting violates the styleguide.

+    return CategoryInfo(base::string16(),
+                        ContentSuggestionsCardLayout::FULL_CARD);
+
+  return iterator->second->GetCategoryInfo(category);
+}
+
 const std::vector<ContentSuggestion>&
 ContentSuggestionsService::GetSuggestionsForCategory(Category category) const {
   auto iterator = suggestions_by_category_.find(category);
   if (iterator == suggestions_by_category_.end())
     return no_suggestions_;
   return iterator->second;
 }
 
 void ContentSuggestionsService::FetchSuggestionImage(
     const std::string& suggestion_id,
@@ skipping 153 matching lines @@
   return true;
 }
 
 void ContentSuggestionsService::NotifyCategoryStatusChanged(Category category) {
   FOR_EACH_OBSERVER(
       Observer, observers_,
       OnCategoryStatusChanged(category, GetCategoryStatus(category)));
 }
 
 }  // namespace ntp_snippets