Add CategoryInfo for meta information of content suggestions Categories

components/ntp_snippets/content_suggestions_service.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_SERVICE_H_
 #define COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_SERVICE_H_
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 58 matching lines @@
   // Inherited from KeyedService.
   void Shutdown() override;
 
   State state() { return state_; }
 
   // Gets all categories for which a provider is registered. The categories
   // may or may not be available, see |GetCategoryStatus()|.
   const std::vector<Category>& GetCategories() const { return categories_; }
 
   // Gets the status of a category.
   CategoryStatus GetCategoryStatus(Category category) const;

[PEConn, 2016/08/04 12:08:39]

Why by value instead of const reference?

[Philipp Keck, 2016/08/04 14:17:43]

Because CategoryStatus is an enum.

In case you meant the CategoryInfo below:
That's currently directly handed through from the provider, which might create
it on stack and return it immediately, so references wouldn't work.
We were thinking about storing the CategoryInfo information somewhere else
though (to enforce it being constant and in order not to loose it when the
provider shuts down the category). But that hasn't happened yet and maybe won't
happen.

 
+  // Gets the meta information of a category.
+  CategoryInfo GetCategoryInfo(Category category) const;
+
   // Gets the available suggestions for a category. The result is empty if the
   // category is available and empty, but also if the category is unavailable
   // for any reason, see |GetCategoryStatus()|.
   const std::vector<ContentSuggestion>& GetSuggestionsForCategory(
       Category category) const;
 
   // Fetches the image for the suggestion with the given |suggestion_id| and
   // runs the |callback|. If that suggestion doesn't exist or the fetch fails,
   // the callback gets an empty image.
   void FetchSuggestionImage(const std::string& suggestion_id,
@@ skipping 102 matching lines @@
   // background fetching and debugging calls to it. If the NTPSnippetsService is
   // loaded, it is also present in |providers_|, otherwise this is a nullptr.
   NTPSnippetsService* ntp_snippets_service_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentSuggestionsService);
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_SERVICE_H_