components/ntp_snippets/category_info.cc - Issue 2207493002: Add CategoryInfo for meta information of content suggestions Categories

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_snippets/category_info.cc

Issue 2207493002: Add CategoryInfo for meta information of content suggestions Categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unnecessary include Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/ntp_snippets/category_info.h ('K') | « components/ntp_snippets/category_info.h ('k') | components/ntp_snippets/content_suggestions_provider.h » ('j') | components/ntp_snippets/content_suggestions_service.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/ntp_snippets/category_info.h"

	6

	7 namespace ntp_snippets {

	8

	9 CategoryInfo::CategoryInfo(const base::string16& title) : title_(title) {}

	10

	11 CategoryInfo::CategoryInfo(CategoryInfo&&) = default;
	PEConn 2016/08/04 12:08:39 If these are just default, why not set them to def If these are just default, why not set them to default in the .h file? Philipp Keck* 2016/08/04 14:17:42 Done. (chromium-style might complain later when we Show quoted text On 2016/08/04 12:08:39, PEConn1 wrote: > If these are just default, why not set them to default in the *.h file? Done. (chromium-style might complain later when we add more fields to the class, but we can always move it back to the cc file then.)
	12

	13 CategoryInfo& CategoryInfo::operator=(CategoryInfo&&) = default;

	14

	15 CategoryInfo::~CategoryInfo() {}

	16

	17 } // namespace ntp_snippets

OLD	NEW