Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2207473004: fixes #26993, constant evaluation gets wrong type (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #26993, constant evaluation gets wrong type like the todo suggested, we need to update staticElement too R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/4c07f7224cd07926dc15a8a6f0c9204f594d3174

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase and sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
4 years, 4 months ago (2016-08-02 23:15:06 UTC) #2
Leaf
lgtm
4 years, 4 months ago (2016-08-02 23:21:56 UTC) #3
Jennifer Messerly
4 years, 4 months ago (2016-08-03 15:51:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4c07f7224cd07926dc15a8a6f0c9204f594d3174 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698