Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2207453002: Properly set the BufferToTextureTargetMap in Blimp (Closed)

Created:
4 years, 4 months ago by David Trainor- moved to gerrit
Modified:
4 years, 4 months ago
Reviewers:
Khushal
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly set the BufferToTextureTargetMap in Blimp Make sure to set the texture target map properly. This is temporary as this code will be going away shortly. Android (and the Linux client) look like they only use GL_TEXTURE_2D for the map entries, so hard coding that for the standalone app. BUG=632418 Committed: https://crrev.com/5ea3a8291f91fcddc9e408b50b736f0d5ea929a1 Cr-Commit-Position: refs/heads/master@{#409213}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unused code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M blimp/client/feature/compositor/blimp_compositor_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.h View 2 chunks +3 lines, -0 lines 0 comments Download
M blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc View 1 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
David Trainor- moved to gerrit
ptal thanks!
4 years, 4 months ago (2016-08-02 02:17:31 UTC) #2
Khushal
lgtm. Thanks! https://codereview.chromium.org/2207453002/diff/1/blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc File blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc (right): https://codereview.chromium.org/2207453002/diff/1/blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc#newcode20 blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc:20: namespace { Doesn't look like GetDefaultBufferToTextureTargetMap is ...
4 years, 4 months ago (2016-08-02 06:39:01 UTC) #7
David Trainor- moved to gerrit
https://codereview.chromium.org/2207453002/diff/1/blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc File blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc (right): https://codereview.chromium.org/2207453002/diff/1/blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc#newcode20 blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc:20: namespace { On 2016/08/02 06:39:01, Khushal wrote: > Doesn't ...
4 years, 4 months ago (2016-08-02 15:37:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207453002/20001
4 years, 4 months ago (2016-08-02 17:06:29 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 17:10:55 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 17:13:59 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ea3a8291f91fcddc9e408b50b736f0d5ea929a1
Cr-Commit-Position: refs/heads/master@{#409213}

Powered by Google App Engine
This is Rietveld 408576698