third_party/WebKit/Source/bindings/scripts/v8_methods.py - Issue 2207423002: Implement '[SecureContext]' IDL attribute for interfaces, methods and attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_methods.py

Issue 2207423002: Implement '[SecureContext]' IDL attribute for interfaces, methods and attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_interface.py ('k') | third_party/WebKit/Source/bindings/scripts/v8_utilities.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_methods.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_methods.py b/third_party/WebKit/Source/bindings/scripts/v8_methods.py

index 002860c69c2312cb08ba7138c508e950bf03cfa9..ee4ba6744d1ad91225e228715b652147206a6b2e 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_methods.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_methods.py

@@ -57,7 +57,9 @@ def method_is_visible(method, interface_is_partial):

def conditionally_exposed(method):

- return method['overloads']['exposed_test_all'] if 'overloads' in method else method['exposed_test']

+ exposed = method['overloads']['exposed_test_all'] if 'overloads' in method else method['exposed_test']

+ secure_context = method['overloads']['secure_context_test_all'] if 'overloads' in method else method['secure_context_test']

+ return exposed or secure_context

def filter_conditionally_exposed(methods, interface_is_partial):

@@ -252,6 +254,7 @@ def method_context(interface, method, is_visible=True):

'property_attributes': property_attributes(interface, method),

'returns_promise': method.returns_promise,

'runtime_enabled_function': v8_utilities.runtime_enabled_function_name(method), # [RuntimeEnabled]

+ 'secure_context_test': v8_utilities.secure_context(method, interface), # [SecureContext]

'should_be_exposed_to_script': not (is_implemented_in_private_script and is_only_exposed_to_private_script),

'use_output_parameter_for_result': idl_type.use_output_parameter_for_result,

'use_local_result': use_local_result(method),