Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2207383002: Revert "[heap] Temporarily use old live object iterator to investigate Win 10 memory regression." (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[heap] Temporarily use old live object iterator to investigate Win 10 memory regression." This reverts commit d2cf6e2956dc4523639ead25569443a07a4e113d. BUG=chromium:633537 Committed: https://crrev.com/62f2e7e8b01404a4253290533d98bb454e820199 Cr-Commit-Position: refs/heads/master@{#38328}

Patch Set 1 #

Patch Set 2 : make sure we do not overflow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -10 lines) Patch
M src/heap/mark-compact-inl.h View 1 1 chunk +51 lines, -10 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +158 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ulan
lgtm
4 years, 4 months ago (2016-08-04 07:55:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207383002/20001
4 years, 4 months ago (2016-08-04 07:56:26 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 08:22:40 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 08:26:33 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/62f2e7e8b01404a4253290533d98bb454e820199
Cr-Commit-Position: refs/heads/master@{#38328}

Powered by Google App Engine
This is Rietveld 408576698