chrome/browser/resources/md_history/history_item.js - Issue 2207323002: [MD History] Factor out a common HistoryListBehavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/history_item.js

Issue 2207323002: [MD History] Factor out a common HistoryListBehavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_history/compiled_resources2.gyp ('K') | « chrome/browser/resources/md_history/grouped_list.js ('k') | chrome/browser/resources/md_history/history_list.html » ('j') | chrome/browser/resources/md_history/history_list.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/history_item.js

diff --git a/chrome/browser/resources/md_history/history_item.js b/chrome/browser/resources/md_history/history_item.js

index 5a3fa265364c27cd8df7618ddb807c0c770451e1..7a1133f5d72f028f0a2c6e672faeb24c4d5d8b12 100644

--- a/chrome/browser/resources/md_history/history_item.js

+++ b/chrome/browser/resources/md_history/history_item.js

@@ -31,7 +31,10 @@ cr.define('md_history', function() {

hasTimeGap: {type: Boolean},

- numberOfItems: {type: Number}

+ numberOfItems: {type: Number},

+ // The path of this history item inside its parent.

+ path: String,

/**

@@ -40,7 +43,9 @@ cr.define('md_history', function() {

* @private

onCheckboxSelected_: function() {

+ // TODO(calamity): Fire this event whenever |selected| changes.

this.fire('history-checkbox-select', {

+ element: this,

countAddition: this.$.checkbox.checked ? 1 : -1

});