Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3667)

Unified Diff: chrome/browser/resources/md_history/compiled_resources2.gyp

Issue 2207323002: [MD History] Factor out a common HistoryListBehavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/compiled_resources2.gyp
diff --git a/chrome/browser/resources/md_history/compiled_resources2.gyp b/chrome/browser/resources/md_history/compiled_resources2.gyp
index 9be96f4e46ad13b599804be41e6849d06fd5bc7a..c67fb851a4ce6713ffad4d05128012b9f4aa0fbb 100644
--- a/chrome/browser/resources/md_history/compiled_resources2.gyp
+++ b/chrome/browser/resources/md_history/compiled_resources2.gyp
@@ -24,6 +24,7 @@
'<(DEPTH)/third_party/polymer/v1_0/components-chromium/iron-collapse/compiled_resources2.gyp:iron-collapse-extracted',
'constants',
'history_item',
+ 'history_list_behavior',
'../history/compiled_resources2.gyp:externs',
],
'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],
@@ -51,11 +52,20 @@
'constants',
'browser_service',
tsergeant 2016/08/09 23:20:00 Nit: I think you can get rid of this
calamity 2016/08/10 04:25:38 Done.
'history_item',
+ 'history_list_behavior',
'../history/compiled_resources2.gyp:externs',
],
'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],
},
{
+ 'target_name': 'history_list_behavior',
+ 'dependencies': [
+ '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:load_time_data',
+ 'browser_service',
+ ],
+ 'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],
+ },
+ {
'target_name': 'history_toolbar',
'dependencies': [
'<(DEPTH)/ui/webui/resources/cr_elements/cr_toolbar/compiled_resources2.gyp:cr_toolbar',
@@ -81,6 +91,7 @@
'dependencies': [
'grouped_list',
'history_list',
+ 'history_list_behavior',
'<(EXTERNS_GYP):chrome_send',
'../history/compiled_resources2.gyp:externs',
],

Powered by Google App Engine
This is Rietveld 408576698