Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: chrome/test/data/webui/md_history/history_list_test.js

Issue 2207323002: [MD History] Factor out a common HistoryListBehavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/md_history/history_list_test.js
diff --git a/chrome/test/data/webui/md_history/history_list_test.js b/chrome/test/data/webui/md_history/history_list_test.js
index f54c605f1a00aeb3628fbd09b6c57c54f5bc685c..c1d62c51121515dfa12113fadf7d9136915586f0 100644
--- a/chrome/test/data/webui/md_history/history_list_test.js
+++ b/chrome/test/data/webui/md_history/history_list_test.js
@@ -34,8 +34,7 @@ cr.define('md_history.history_list_test', function() {
test('cancelling selection of multiple items', function() {
app.historyResult(createHistoryInfo(), TEST_HISTORY_RESULTS);
return flush().then(function() {
- var items =
- Polymer.dom(element.root).querySelectorAll('history-item');
+ var items = polymerQuerySelectorAll(element, 'history-item');
MockInteractions.tap(items[2].$.checkbox);
MockInteractions.tap(items[3].$.checkbox);
@@ -65,8 +64,7 @@ cr.define('md_history.history_list_test', function() {
app.historyResult(createHistoryInfo(), TEST_HISTORY_RESULTS);
return flush().then(function() {
- var items =
- Polymer.dom(element.root).querySelectorAll('history-item');
+ var items = polymerQuerySelectorAll(element, 'history-item');
assertTrue(items[0].isCardStart);
assertTrue(items[0].isCardEnd);
assertFalse(items[1].isCardEnd);
@@ -83,7 +81,7 @@ cr.define('md_history.history_list_test', function() {
return flush().then(function() {
var items =
- Polymer.dom(element.root).querySelectorAll('history-item');
+ polymerQuerySelectorAll(element, 'history-item');
assertTrue(items[3].isCardStart);
assertTrue(items[5].isCardEnd);
@@ -100,14 +98,13 @@ cr.define('md_history.history_list_test', function() {
app.historyResult(createHistoryInfo(), ADDITIONAL_RESULTS);
return flush().then(function() {
- element.removeDeletedHistory_([
- element.historyData_[2], element.historyData_[5],
- element.historyData_[7]
+ element.removeItemsByPath([
+ 'historyData_.2', 'historyData_.5', 'historyData_.7'
]);
return flush();
}).then(function() {
- items = Polymer.dom(element.root).querySelectorAll('history-item');
+ items = polymerQuerySelectorAll(element, 'history-item');
assertEquals(element.historyData_.length, 5);
assertEquals(element.historyData_[0].dateRelativeDay,
@@ -184,7 +181,7 @@ cr.define('md_history.history_list_test', function() {
app.historyResult(createHistoryInfo(), TEST_HISTORY_RESULTS);
return flush().then(function() {
- items = Polymer.dom(element.root).querySelectorAll('history-item');
+ items = polymerQuerySelectorAll(element, 'history-item');
MockInteractions.tap(items[2].$['menu-button']);
assertTrue(sharedMenu.menuOpen);
@@ -217,7 +214,7 @@ cr.define('md_history.history_list_test', function() {
app.historyResult(createHistoryInfo(), TEST_HISTORY_RESULTS);
app.historyResult(createHistoryInfo(), ADDITIONAL_RESULTS);
flush().then(function() {
- items = Polymer.dom(element.root).querySelectorAll('history-item');
+ items = polymerQuerySelectorAll(element, 'history-item');
MockInteractions.tap(items[2].$.checkbox);
MockInteractions.tap(items[5].$.checkbox);
@@ -226,6 +223,7 @@ cr.define('md_history.history_list_test', function() {
registerMessageCallback('removeVisits', this, function() {
flush().then(function() {
deleteComplete();
+ return flush();
}).then(function() {
assertEquals(element.historyData_.length, 5);
assertEquals(element.historyData_[0].dateRelativeDay,
@@ -235,6 +233,15 @@ cr.define('md_history.history_list_test', function() {
assertEquals(element.historyData_[4].dateRelativeDay,
'2016-03-11');
assertFalse(listContainer.$.dialog.open);
+
+ // Ensure the UI is correctly updated.
+ items = polymerQuerySelectorAll(element, 'history-item');
+ assertEquals('https://www.google.com', items[0].item.title);
+ assertEquals('https://www.example.com', items[1].item.title);
+ assertEquals('https://en.wikipedia.org', items[2].item.title);
+ assertEquals('https://en.wikipedia.org', items[3].item.title);
+ assertEquals('https://www.google.com', items[4].item.title);
+
done();
});
});
@@ -252,7 +259,7 @@ cr.define('md_history.history_list_test', function() {
var listContainer = app.$.history;
app.historyResult(createHistoryInfo(), TEST_HISTORY_RESULTS);
flush().then(function() {
- items = Polymer.dom(element.root).querySelectorAll('history-item');
+ items = polymerQuerySelectorAll(element, 'history-item');
// Dialog should not appear when there is no item selected.
MockInteractions.pressAndReleaseKeyOn(

Powered by Google App Engine
This is Rietveld 408576698