Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Unified Diff: chrome/browser/resources/md_history/list_container.js

Issue 2207323002: [MD History] Factor out a common HistoryListBehavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/list_container.js
diff --git a/chrome/browser/resources/md_history/list_container.js b/chrome/browser/resources/md_history/list_container.js
index 93d430d098c6298aea140073b56f7115f9d31d2b..74d199479b02871bcc426c33f522fe4566fff04d 100644
--- a/chrome/browser/resources/md_history/list_container.js
+++ b/chrome/browser/resources/md_history/list_container.js
@@ -85,8 +85,7 @@ Polymer({
},
unselectAllItems: function(count) {
- /** @type {HistoryListElement} */ (this.$['infinite-list'])
- .unselectAllItems(count);
+ this.$.content.selectedItem.unselectAllItems(count);
tsergeant 2016/08/05 01:39:09 Nit: Maybe extract this.$.content.selectedItem int
calamity 2016/08/09 02:56:00 So this is exactly why I was asking how behaviors
tsergeant 2016/08/09 04:37:54 That's unfortunate. I think it would be worthwhile
calamity 2016/08/09 05:28:30 Done.
},
/**
@@ -140,7 +139,7 @@ Polymer({
/** @private */
onDialogConfirmTap_: function() {
- this.$['infinite-list'].deleteSelected();
+ this.$.content.selectedItem.deleteSelected();
this.$.dialog.close();
},
@@ -182,7 +181,7 @@ Polymer({
md_history.BrowserService.getInstance()
.deleteItems([menu.itemData])
.then(function(items) {
- this.$['infinite-list'].removeDeletedHistory_(items);
+ this.$.content.selectedItem.removeItemsByPath(items[0].path);
// This unselect-all is to reset the toolbar when deleting a selected
// item. TODO(tsergeant): Make this automatic based on observing list
// modifications.

Powered by Google App Engine
This is Rietveld 408576698